From: Lars-Peter Clausen <lars@metafoo.de>
To: Denis Ciocca <denis.ciocca@gmail.com>
Cc: jic23@kernel.org, linux-iio@vger.kernel.org
Subject: Re: STMicroelectronics IIO driver
Date: Mon, 28 Jan 2013 15:31:10 +0100 [thread overview]
Message-ID: <51068BAE.9090801@metafoo.de> (raw)
In-Reply-To: <1359157488-15969-1-git-send-email-denis.ciocca@st.com>
On 01/26/2013 12:44 AM, Denis Ciocca wrote:
> Hi Jonathan, Lars,
>
> I modified the drivers following the advice of Lars (about code duplication) and Jonathan patches.
> I also used coccicheck to verify the code. I couldn't test the drivers on the physical devices because I was not in office. I hope to do some tests Monday morning.
>
> Thanks and Best Regards,
>
> Denis
>
Hi,
I think the driver is now in a state where we can merge it, good work.
There are one or two rough edges left, but no blockers and nothing that
can't be fixed in follow up patches. (And to be honest I'm kind of tired of
reviewing the same code over and over again ;))
So for the whole series:
Reviewed-by: Lars-Peter Clausen <lars@metafoo.de>
- Lars
next prev parent reply other threads:[~2013-01-28 14:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-25 23:44 STMicroelectronics IIO driver Denis Ciocca
2013-01-25 23:44 ` [PATCH 1/4] iio:common: Add STMicroelectronics common library Denis Ciocca
2013-01-29 21:45 ` Lars-Peter Clausen
2013-01-25 23:44 ` [PATCH 2/4] iio:accel: Add STMicroelectronics accelerometers driver Denis Ciocca
2013-01-25 23:44 ` [PATCH 3/4] iio:gyro: Add STMicroelectronics gyroscopes driver Denis Ciocca
2013-01-25 23:44 ` [PATCH 4/4] iio:magnetometer: Add STMicroelectronics magnetometers driver Denis Ciocca
2013-01-28 14:31 ` Lars-Peter Clausen [this message]
2013-01-28 20:14 ` STMicroelectronics IIO driver Jonathan Cameron
2013-01-29 9:51 ` Denis CIOCCA
2013-01-30 21:28 ` Jonathan Cameron
2013-01-31 10:18 ` Denis CIOCCA
2013-01-29 9:55 ` Denis CIOCCA
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51068BAE.9090801@metafoo.de \
--to=lars@metafoo.de \
--cc=denis.ciocca@gmail.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).