Linux IIO development
 help / color / mirror / Atom feed
From: Lars-Peter Clausen <lars@metafoo.de>
To: Chris Micali <chrismicali@gmail.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
	"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>
Subject: Re: IIO Drivers
Date: Wed, 27 Feb 2013 21:02:21 +0100	[thread overview]
Message-ID: <512E664D.2040405@metafoo.de> (raw)
In-Reply-To: <69F22814D4E34BA292A240F114EAA970@gmail.com>

On 02/27/2013 08:50 PM, Chris Micali wrote:
> Last question :)  I'd like to sample from this device as quickly as possible - so I'm assuming I need to trigger quickly?  Should I use iio-trig-periodic-rtc?  Any hints/instructions on how to use that?  Should the driver supply it's own trigger that uses an hrtimer instead?
> 
> Thanks!
> Chris

Hi,

There is a generic hrtimer based trigger:
https://github.com/lclausen-adi/linux-2.6/commit/a3b5c3f7aafbcac562d6f00a6589b110bd9fb71c

Unfortunately it's not upstream ready yet.

I can be registered via a platform_device

static struct platform_device iio_trigger_hrtimer = {
	.name = "iio-trigger-hrtimer",
	.id = 0,
};

- Lars

> 
> 
> On Wednesday, February 27, 2013 at 2:32 PM, Chris Micali wrote:  
>> Guys,  
>>  
>> Thanks a lot for the help! I finally tracked down issues, it was a combination of a few things:
>>  
>> 1. The .channel had to be 0, not 1 in the driver (scan_index didn't matter)
>> 2. 1 or more scan_elements have to be enabled as you mentioned
>> 2. When echoing into the sysfs files it has to have a space after the number (cat 1 > in_voltage0_en and not cat 1>in_vo…) (duh!)
>> 3. The generic_buffer.c program had a few bugs in it causing crashes. I updated the iio_utils.h to a newer version I found here: https://github.com/analogdevicesinc/iio-oscilloscope and then made a few modifications (the newer iio_utils did not parse a few things right in the channel details like bigendian/littleendian)
>>  
>> So generic_buffer is now correctly sampling (although it crashes after a couple, it's probably another iio_utils issue)
>>  
>> Thanks!!
>>  
>> -chris
>>  
>>  
>> On Wednesday, February 27, 2013 at 1:51 PM, Lars-Peter Clausen wrote:
>>  
>>> On 02/27/2013 07:28 PM, Jonathan Cameron wrote:
>>>> On 02/27/2013 05:36 PM, Chris Micali wrote:
>>>>> lars,  
>>>>>  
>>>>> I was under the impression that flag gets added automatically by iio_triggered_buffer_setup (industrialiio-triggers.c:77) - I actually am now able to enable the scan_element after changing my channel .channel and .scan_index to 0 (trying to match exactly the other drivers.)
>>>  
>>>  
>>> Yea, you are right I missed the iio_triggered_buffer_setup part.
>>>  
>>>> Strange, scan_index should have defaulted to zero and the .channel value shouldn't have mattered
>>>> for buffered reads (just effects naming). Might have caused issues with userspace expecting a channel 0
>>>> though...
>>>  
>>>  
>>>  
>>>  
>>>  
>>> I guess the scan_index had nothing to do with this, but I suggested to set
>>> scan_elements/in_voltage0_en to 1, so this clearly wouldn't have worked with
>>> .channel being 1.
>>>  
>>>>  
>>>>> When i run general_buffer (from the docs dir) with that scan element enabled it can no longer read the trigger (Could not open /trigger/current_trigger Failed to write current_trigger file) - this succeeds if that scan_element is not enabled.  
>>>  
>>>  
>>> You can't change the trigger if the buffer is currently enabled. Make sure that
>>> he buffer is disabled (check the buffer/enable attribute).
>>>  
>>> - Lars
>>> u
>>  
> 
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


  reply	other threads:[~2013-02-27 20:00 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <26387F1A648A4D3D9BB4142C4F0AAE98@gmail.com>
2013-02-27 16:07 ` IIO Drivers Lars-Peter Clausen
2013-02-27 16:21   ` Chris Micali
2013-02-27 16:34     ` Lars-Peter Clausen
     [not found]       ` <4AEA8015FE824807B3CF62B7B35FC5D3@gmail.com>
2013-02-27 17:34         ` Lars-Peter Clausen
2013-02-27 17:36           ` Chris Micali
2013-02-27 18:28             ` Jonathan Cameron
2013-02-27 18:51               ` Lars-Peter Clausen
2013-02-27 19:32                 ` Chris Micali
2013-02-27 19:50                   ` Chris Micali
2013-02-27 20:02                     ` Lars-Peter Clausen [this message]
2013-02-27 20:06                       ` Chris Micali
2013-02-27 20:15                         ` Lars-Peter Clausen
2013-02-27 20:25                           ` Chris Micali
2013-03-02 16:27                   ` Jonathan Cameron
2013-03-04 20:37                     ` Chris Micali
2013-03-05 21:06                       ` Lars-Peter Clausen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=512E664D.2040405@metafoo.de \
    --to=lars@metafoo.de \
    --cc=chrismicali@gmail.com \
    --cc=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox