From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f170.google.com (mail-oi1-f170.google.com [209.85.167.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 34D123806AF for ; Thu, 9 Jul 2026 15:54:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783612484; cv=none; b=BwnYcaDIocuWpKQisxmD2+v0yR7I5RPDBIclA2f/npeCYLy260rY+YW5fVCFiHqsJaDaAPfba1d57Q60Q4K96QbpKJX7F80R6Xv4c0ODQlfgTH24sEQPseNfO9P1aXgitiOI8qlYOwJS3QoFKwLPB2Krda6GHLB2bNbvcWB1O98= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783612484; c=relaxed/simple; bh=PLoGulolsNch+biEk21nQng2ImxUq6L8OXGcxAC3fPk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ZxWuty9sJ5FevzH6oLkmHH661+QxdGU3QyefQNcRxQaHVVWd9UvxCUztHsi5zMfxJUHCL7zz8cNpLaxPWGoliW26uLnFbQL1FV0jpe5xsvNDm9QFeRJ8/3gFmN07s9MYq4UfYafCHGQwbKE+WIFMX3sD6buyWOT8dyKWlLwvUF8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=SyFWovOc; arc=none smtp.client-ip=209.85.167.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="SyFWovOc" Received: by mail-oi1-f170.google.com with SMTP id 5614622812f47-495b98b4f6aso393674b6e.2 for ; Thu, 09 Jul 2026 08:54:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1783612480; x=1784217280; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=LoJZzYBp1oB4KO4xVaDbxz5nVfTJ4PzYKcsEvK7N4q4=; b=SyFWovOc2/JnIM7UW2tlc0zHngTi1DwrmYmGFPF/ZXAaeuHvpMevVR2+i4J1gZG/0i lUMW95P0nDvl1L/NDYUh05FQc0Hg7FzpQ+UYiRmmgl7zteZvEfbHyjoHN4QhA0c8kN1J rBPNiKw2PJ6lYoylU6epf4oIH5M9wg3AuOdn4iTkLjNjyen+BixMjmQG46H5hn0/lB57 yR/oqVuDF/oyw4vWN1S/ToGOiDr67+rZ1VU7aQDuvovEZtZwO+Qs16+U78s3yg0v1hNM PCDlfHGQuxWREDgcN1WbOeBSw7o4FPCF/GjjmQ5UPuJEjL977pNIYiZzP45ZtNc5D+Bz nb2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783612480; x=1784217280; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=LoJZzYBp1oB4KO4xVaDbxz5nVfTJ4PzYKcsEvK7N4q4=; b=maC+R4f712lTjvmzLRuhCqDsuSzsO9tThMZNKzPGNB/gFxDiCSTcuZyEZgKP8l7/7R Q56G7ZZTLtE53NSjcbIBhNQKJ9bqUqD2Yte+YVDIQSb6Jj68Cpl9rLYUuYQIBdZLEr05 Ehktj7sNbh6KJ+QSAE4BEiIFcbvYbtLvkewsmAjMpSO3YrguiVYWMXbGrtn8ip/dnzMr DbXOKo0g3+kkr1cLLXv4HzAjVRkpdWEhEhillC4aasum6ZYu2EPLJVTDSRF0GxEBL5fp GLhgjKNGh4XxnH6JI2rsGCbW6rYaFT4mn9s1dCnONTzHwJFQEJDoYu2XWW8rBASCVNFS KX8A== X-Forwarded-Encrypted: i=1; AFNElJ9zJMHko5B/pI1TbKfCa9ZNALarWB5jglXouGvxazKm2xCxkKnsFmK7dYiukOzThNgkVG4w0XSeXdc=@vger.kernel.org X-Gm-Message-State: AOJu0YyBElv2jM3ExIbMUC6GNpUxRtlxMlEEe2hRPcz0TW6tSsEoZzX6 puKkRWDCNdtJ2azkaaN/QnfWxQHsGyldTOPCoGhiiGO7+hUk8g7pGlLTvjAOKmjfrkA= X-Gm-Gg: AfdE7clf96k0Uh+SylTo5ag6LiZojrMQqoqOo7QB9h0bnUmZwShtg9MCX8jilJVt3fI zlTB7CiWRT1inhF2DTFIDvv3miATvRSmK2JLasUdwF+FV8te/m65C6Ck7wCzg6YUu3YZT94KMvy i9aiHW2aIR2eXncsGAs8iKm7cdCKLpOu2epnKgbIY2IQqEAorO5crK77ed/UY5Jg2Yuw8V1e9O1 FXcxRUAYePFdFaAzxXWYFg1wxy+en7EeJyjJwqp9d3y8mo1jZw1KZIu5hn2ScCjnqPcBDxV+iQ9 K1yXzTGJnoNgaXgp9iSR79TFem2JwPiG4Dpkgn6pbJLdZ66j2ek1dFifG5MqH9tCxf4I4KEFUdX 8pyXfQ4iIhP+EDnqf+HjQAwh6fYSJW/LJzN8Y6F8fi0IV7aKvX8nxXmDoy5D2ezA/uvuM5JmFk4 /OF6En75NQY4bNLiIPBAniJPW2i7K3nIrtfQIFAFqjVQ3L/YRL5r8j+QQSPsUvGGE= X-Received: by 2002:a05:6808:3086:b0:496:b7c:274b with SMTP id 5614622812f47-4a202e98156mr8019702b6e.19.1783612480192; Thu, 09 Jul 2026 08:54:40 -0700 (PDT) Received: from ?IPV6:2600:8803:e7e4:500:2a8b:8d9e:f359:9a35? ([2600:8803:e7e4:500:2a8b:8d9e:f359:9a35]) by smtp.gmail.com with ESMTPSA id 5614622812f47-4a1adca6bedsm4124082b6e.8.2026.07.09.08.54.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Jul 2026 08:54:39 -0700 (PDT) Message-ID: <517f688a-6958-473f-bd4d-65dcb56278cb@baylibre.com> Date: Thu, 9 Jul 2026 10:54:37 -0500 Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/6] iio: adc: adi-axi-adc: Add support for CRC To: Janani Sunil , =?UTF-8?Q?Nuno_S=C3=A1?= , Michael Hennerich , Jonathan Cameron , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Olivier Moysan , Philipp Zabel , Linus Walleij , Bartosz Golaszewski , Jonathan Corbet , Shuah Khan Cc: linux@analog.com, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-doc@vger.kernel.org, jananisunil.dev@gmail.com References: <20260709-ad7768-driver-v1-0-44e1194fd96a@analog.com> <20260709-ad7768-driver-v1-3-44e1194fd96a@analog.com> Content-Language: en-US From: David Lechner In-Reply-To: <20260709-ad7768-driver-v1-3-44e1194fd96a@analog.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 7/9/26 3:50 AM, Janani Sunil wrote: > Add support for enabling and disabling Cyclic Redundancy Check (CRC) > processing in the AXI ADC backend. CRC provides data integrity verification > for high-speed ADC data streams, ensuring reliable data transfer between > the ADC frontend and backend processing systems. > > Signed-off-by: Janani Sunil > --- > drivers/iio/adc/adi-axi-adc.c | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) > > diff --git a/drivers/iio/adc/adi-axi-adc.c b/drivers/iio/adc/adi-axi-adc.c > index 26b9c75bd4d8..8af42d26aac0 100644 > --- a/drivers/iio/adc/adi-axi-adc.c > +++ b/drivers/iio/adc/adi-axi-adc.c > @@ -47,6 +47,8 @@ > #define ADI_AXI_ADC_CTRL_DDR_EDGESEL_MASK BIT(1) > > #define ADI_AXI_ADC_REG_CNTRL_3 0x004c > +#define ADI_AXI_ADC_REG_CNTRL3_CRC_EN_MASK BIT(8) ADI_AXI_ADC_CNTRL_3_CRC_EN_MASK to match the existing naming pattern. Also, add a comment that bit 8 is shared by all AXI ADC cores while bits 7-0 are custom per HDL project. (That is why they have names like AD485X instead of AXI_ADC). > + > #define AXI_AD485X_CNTRL_3_OS_EN_MSK BIT(2) > #define AXI_AD485X_CNTRL_3_PACKET_FORMAT_MSK GENMASK(1, 0) > #define AXI_AD485X_PACKET_FORMAT_20BIT 0x0 > @@ -567,6 +569,22 @@ static int axi_adc_reg_access(struct iio_backend *back, unsigned int reg, > return regmap_write(st->regmap, reg, writeval); > } >