From: Jonathan Cameron <jic23@kernel.org>
To: Jan Luebbe <jlu@pengutronix.de>
Cc: Pantelis Antoniou <panto@antoniou-consulting.com>,
rachna@ti.com, linux-iio@vger.kernel.org,
linux-omap@vger.kernel.org,
Koen Kooi <koen@dominion.thruhere.net>
Subject: Re: [PATCH] ti_tscadc: Update with IIO map interface & deal with partial activation
Date: Mon, 06 May 2013 17:12:05 +0100 [thread overview]
Message-ID: <5187D655.1010402@kernel.org> (raw)
In-Reply-To: <1367844539-6812-1-git-send-email-jlu@pengutronix.de>
On 05/06/2013 01:48 PM, Jan Luebbe wrote:
> Hi Pantelis,
>
> while trying out your patch on a custom AM335x board, I noticed that the
> sysfs entries ware missing. This is fixed in the first patch, you might want
> to squash that into your original patch.
>
> The second one makes sure that the iio framework does not read invalid data.
>
> Regards,
> Jan
I don't believe Pantelis ever came back with a response to the various issues
raised with the original patches?
If Pantelis has moved on, Jan feel free to pick up the patches, respin them
and resend to linux-iio if you like (with appropriate crediting naturally)
Until these are appropriately fixed up and resent, I'm lazy so will ignore these.
(your patches look reasonable to me based on a really superficial look)
Jonathan
next prev parent reply other threads:[~2013-05-06 16:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-31 15:55 [PATCH] ti_tscadc: Update with IIO map interface & deal with partial activation Pantelis Antoniou
2012-10-30 18:28 ` Lars-Peter Clausen
2013-05-06 12:48 ` Jan Luebbe
2013-05-06 12:48 ` [PATCH 1/2] iio: adc: ti_am335x_adc: revert info_mask removal Jan Luebbe
2013-05-06 12:48 ` [PATCH 2/2] iio: adc: ti_am335x_adc: make tiadc_read_raw() more robust Jan Luebbe
2013-05-06 16:12 ` Jonathan Cameron [this message]
2013-05-07 13:08 ` [PATCH] ti_tscadc: Update with IIO map interface & deal with partial activation Pantelis Antoniou
2013-05-07 14:09 ` Jan Lübbe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5187D655.1010402@kernel.org \
--to=jic23@kernel.org \
--cc=jlu@pengutronix.de \
--cc=koen@dominion.thruhere.net \
--cc=linux-iio@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=panto@antoniou-consulting.com \
--cc=rachna@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox