From: Jacek Anaszewski <j.anaszewski@samsung.com>
To: linux-iio@vger.kernel.org
Cc: public-jic23-DgEjT+Ai2ygdnm+yROfE0A@plane.gmane.org,
public-linux-iio-u79uwXL29TY76Z2rM5mHXA@plane.gmane.org,
public-lars-Qo5EllUWu/uELgA04lAiVw@plane.gmane.org
Subject: Re: [PATCH 3/3] iio:pressure: Add STMicroelectronics pressures driver
Date: Fri, 17 May 2013 17:00:21 +0200 [thread overview]
Message-ID: <51964605.6050707@samsung.com> (raw)
In-Reply-To: <1368607493-4843-4-git-send-email-denis.ciocca@st.com>
On 05/15/2013 10:44 AM, Denis CIOCCA wrote:
> This patch adds a generic pressure driver for STMicroelectronics
> pressures, currently it supports: LPS331AP.
>
> Signed-off-by: Denis Ciocca<denis.ciocca@st.com>
Hi Denis,
I have tested your driver with Samsung Exynos4x12 PQ/M0 board and in
general it works fine, except of one issue.
Triggers can be used only when INT1 interrupt source is exploited.
On the test board I am using there is INT2 interrupt source routed to
the CPU, and I had to change ST_PRESS_1_DRDY_IRQ_MASK constant defined
in the st_pressure_core.c file to 0x20, to instruct the device to
to generate the 'data ready' interrupts on the INT2 pin.
I think that information about used interrupt source should be passed
through platform_data and/or of_tree. For the of_tree there is ready
solution available in my patch for this barometer.
Thanks,
Jacek
next prev parent reply other threads:[~2013-05-17 15:00 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-15 8:44 STMicroelectronics pressure sensors driver Denis CIOCCA
2013-05-15 8:44 ` [PATCH 1/3] iio:common: ST_SENSORS_LSM_CHANNELS macro changed Denis CIOCCA
2013-05-18 20:23 ` Jonathan Cameron
2013-05-15 8:44 ` [PATCH 2/3] iio:common: Added get_buffer_element function pointer Denis CIOCCA
2013-05-18 20:33 ` Jonathan Cameron
2013-05-15 8:44 ` [PATCH 3/3] iio:pressure: Add STMicroelectronics pressures driver Denis CIOCCA
2013-05-17 15:00 ` Jacek Anaszewski [this message]
2013-05-17 16:09 ` Denis CIOCCA
2013-05-18 21:06 ` Jonathan Cameron
2013-05-20 7:51 ` Denis CIOCCA
2013-05-20 9:47 ` Jacek Anaszewski
2013-05-22 21:27 ` Jonathan Cameron
2013-05-22 21:29 ` Jonathan Cameron
-- strict thread matches above, loose matches on Subject: below --
2013-05-24 14:25 Support pressure sensors Denis CIOCCA
2013-05-24 14:25 ` [PATCH 3/3] iio:pressure: Add STMicroelectronics pressures driver Denis CIOCCA
2013-06-03 14:58 STMicroelectronics series of patches to support pressure sensors Denis CIOCCA
2013-06-03 14:58 ` [PATCH 3/3] iio:pressure: Add STMicroelectronics pressures driver Denis CIOCCA
2013-06-04 18:03 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51964605.6050707@samsung.com \
--to=j.anaszewski@samsung.com \
--cc=linux-iio@vger.kernel.org \
--cc=public-jic23-DgEjT+Ai2ygdnm+yROfE0A@plane.gmane.org \
--cc=public-lars-Qo5EllUWu/uELgA04lAiVw@plane.gmane.org \
--cc=public-linux-iio-u79uwXL29TY76Z2rM5mHXA@plane.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).