From: Jonathan Cameron <jic23@kernel.org>
To: Jacek Anaszewski <j.anaszewski@samsung.com>
Cc: linux-iio@vger.kernel.org,
Jonathan Cameron
<public-jic23-DgEjT+Ai2ygdnm+yROfE0A@plane.gmane.org>,
"linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<public-linux-iio-u79uwXL29TY76Z2rM5mHXA@plane.gmane.org>,
"lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org"
<public-lars-Qo5EllUWu/uELgA04lAiVw@plane.gmane.org>,
"j.anaszewski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org"
<public-j.anaszewski-Sze3O3UU22JBDgjK7y7TUQ@plane.gmane.org>
Subject: Re: [PATCH 3/3] iio:pressure: Add STMicroelectronics pressures driver
Date: Wed, 22 May 2013 22:29:33 +0100 [thread overview]
Message-ID: <519D38BD.2080604@kernel.org> (raw)
In-Reply-To: <519D3858.8070306@kernel.org>
On 05/22/2013 10:27 PM, Jonathan Cameron wrote:
> On 05/20/2013 10:47 AM, Jacek Anaszewski wrote:
>> On 05/20/2013 09:51 AM, Denis CIOCCA wrote:
>>> Hi Jonathan,
>>>
>>>> Now going forward I'd of course like to see everyone happy with the
>>>> resulting driver. Denis do you have plans to implement the threshold
>>>> events that were in the other driver proposal?
>>> Now I'm very full but in the future I have plans to support the threshold
>>> events, I'm very happy if Jacek will help me! ;)
>>
>> Hi Jonathan, Denis,
>>
>> The threshold events weren't supported in my driver proposal - the events were related only to the 'data ready'
>> interrupts. I've been
>> playing with threshold interrupts during development, but I didn't
>> find the device reliable by minimal threshold levels.
> Oops, I missed that you were 'abusing' these entirely in review.
>
>> I've lately
>> devised a procedure of testing greater pressure differences and
>> I will test it within few weeks, as currently I am working on
>> another driver.
> Given the driver simplicity (as it's adding to the existing drivers that
> are well tested) I'm going to assume it works fine for now
> and merge it based on review. Do shout if it doesn't of course
> or if you have any improvements to suggest.
Actually no I'm not. I'd completely forgotten that I wasn't happy with some of
the patches during review. Over to Denis to post a new version or convince
me the review comments were wrong ;)
>
> I'd definitely like to see full event support for the threshold interrupts
> in these parts (which will be needed to finally kill off the my lis3l02dq
> driver :) Been trying to get rid of that one for years.).
>
> Jonathan
>>
>> Thanks,
>> Jacek
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2013-05-22 21:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-15 8:44 STMicroelectronics pressure sensors driver Denis CIOCCA
2013-05-15 8:44 ` [PATCH 1/3] iio:common: ST_SENSORS_LSM_CHANNELS macro changed Denis CIOCCA
2013-05-18 20:23 ` Jonathan Cameron
2013-05-15 8:44 ` [PATCH 2/3] iio:common: Added get_buffer_element function pointer Denis CIOCCA
2013-05-18 20:33 ` Jonathan Cameron
2013-05-15 8:44 ` [PATCH 3/3] iio:pressure: Add STMicroelectronics pressures driver Denis CIOCCA
2013-05-17 15:00 ` Jacek Anaszewski
2013-05-17 16:09 ` Denis CIOCCA
2013-05-18 21:06 ` Jonathan Cameron
2013-05-20 7:51 ` Denis CIOCCA
2013-05-20 9:47 ` Jacek Anaszewski
2013-05-22 21:27 ` Jonathan Cameron
2013-05-22 21:29 ` Jonathan Cameron [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-05-24 14:25 Support pressure sensors Denis CIOCCA
2013-05-24 14:25 ` [PATCH 3/3] iio:pressure: Add STMicroelectronics pressures driver Denis CIOCCA
2013-06-03 14:58 STMicroelectronics series of patches to support pressure sensors Denis CIOCCA
2013-06-03 14:58 ` [PATCH 3/3] iio:pressure: Add STMicroelectronics pressures driver Denis CIOCCA
2013-06-04 18:03 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=519D38BD.2080604@kernel.org \
--to=jic23@kernel.org \
--cc=j.anaszewski@samsung.com \
--cc=linux-iio@vger.kernel.org \
--cc=public-j.anaszewski-Sze3O3UU22JBDgjK7y7TUQ@plane.gmane.org \
--cc=public-jic23-DgEjT+Ai2ygdnm+yROfE0A@plane.gmane.org \
--cc=public-lars-Qo5EllUWu/uELgA04lAiVw@plane.gmane.org \
--cc=public-linux-iio-u79uwXL29TY76Z2rM5mHXA@plane.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).