linux-iio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Jingoo Han <jg1.han@samsung.com>
Cc: 'Jonathan Cameron' <jic23@cam.ac.uk>, linux-iio@vger.kernel.org
Subject: Re: [PATCH] iio: replace strict_strtoul() with kstrtoul()
Date: Sun, 02 Jun 2013 17:06:00 +0100	[thread overview]
Message-ID: <51AB6D68.2080207@kernel.org> (raw)
In-Reply-To: <000401ce5e97$2aa80490$7ff80db0$@samsung.com>

On 06/01/2013 08:10 AM, Jingoo Han wrote:
> The usage of strict_strtoul() is not preferred, because
> strict_strtoul() is obsolete. Thus, kstrtoul() should be
> used.
> 
hmmm.  Normally I'd only take this sort of change
if it were part of a large scale cleanup of a driver, but
as those are both my drivers what the heck, I'll take it.

Applied to the togreg branch of iio.git.

> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
>  drivers/iio/adc/max1363.c            |    2 +-
>  drivers/iio/trigger/iio-trig-sysfs.c |    4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/iio/adc/max1363.c b/drivers/iio/adc/max1363.c
> index 9e6da72..f148d00 100644
> --- a/drivers/iio/adc/max1363.c
> +++ b/drivers/iio/adc/max1363.c
> @@ -660,7 +660,7 @@ static ssize_t max1363_monitor_store_freq(struct device *dev,
>  	unsigned long val;
>  	bool found = false;
>  
> -	ret = strict_strtoul(buf, 10, &val);
> +	ret = kstrtoul(buf, 10, &val);
>  	if (ret)
>  		return -EINVAL;
>  	for (i = 0; i < ARRAY_SIZE(max1363_monitor_speeds); i++)
> diff --git a/drivers/iio/trigger/iio-trig-sysfs.c b/drivers/iio/trigger/iio-trig-sysfs.c
> index b727bde..effcd0a 100644
> --- a/drivers/iio/trigger/iio-trig-sysfs.c
> +++ b/drivers/iio/trigger/iio-trig-sysfs.c
> @@ -34,7 +34,7 @@ static ssize_t iio_sysfs_trig_add(struct device *dev,
>  	int ret;
>  	unsigned long input;
>  
> -	ret = strict_strtoul(buf, 10, &input);
> +	ret = kstrtoul(buf, 10, &input);
>  	if (ret)
>  		return ret;
>  	ret = iio_sysfs_trigger_probe(input);
> @@ -53,7 +53,7 @@ static ssize_t iio_sysfs_trig_remove(struct device *dev,
>  	int ret;
>  	unsigned long input;
>  
> -	ret = strict_strtoul(buf, 10, &input);
> +	ret = kstrtoul(buf, 10, &input);
>  	if (ret)
>  		return ret;
>  	ret = iio_sysfs_trigger_remove(input);
> 

      reply	other threads:[~2013-06-02 16:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-01  7:10 [PATCH] iio: replace strict_strtoul() with kstrtoul() Jingoo Han
2013-06-02 16:06 ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51AB6D68.2080207@kernel.org \
    --to=jic23@kernel.org \
    --cc=jg1.han@samsung.com \
    --cc=jic23@cam.ac.uk \
    --cc=linux-iio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).