From: Michael Hennerich <michael.hennerich@analog.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: <linux-iio@vger.kernel.org>, <dan.carpenter@oracle.com>
Subject: Re: [PATCH 1/4] iio: frequency: ad4350: Fix bug / typo in mask
Date: Mon, 3 Jun 2013 10:20:54 +0200 [thread overview]
Message-ID: <51AC51E6.80108@analog.com> (raw)
In-Reply-To: <51AB6E79.7070108@kernel.org>
On 06/02/2013 06:10 PM, Jonathan Cameron wrote:
> On 05/23/2013 04:00 PM, michael.hennerich@analog.com wrote:
>> From: Michael Hennerich <michael.hennerich@analog.com>
> I got lost in the original discussion.
>
> Is this a fix for the current cycle, or does it want to go with the
> rest of the series, for the next one?
>
> I'm guessing you'll do a refreshed version with the bits in patch
> 4 fixed up so I'll wait for that to apply it.
Hi Jonathan,
I'll send out a new series shortly - 1/4 is fixing a bug -
if it can go into the current cycle that would be good.
>
> Jonathan
>> Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>
>> ---
>> drivers/iio/frequency/adf4350.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/iio/frequency/adf4350.c b/drivers/iio/frequency/adf4350.c
>> index a884252..e76d4ac 100644
>> --- a/drivers/iio/frequency/adf4350.c
>> +++ b/drivers/iio/frequency/adf4350.c
>> @@ -212,7 +212,7 @@ static int adf4350_set_freq(struct adf4350_state *st, unsigned long long freq)
>> (pdata->r2_user_settings & (ADF4350_REG2_PD_POLARITY_POS |
>> ADF4350_REG2_LDP_6ns | ADF4350_REG2_LDF_INT_N |
>> ADF4350_REG2_CHARGE_PUMP_CURR_uA(5000) |
>> - ADF4350_REG2_MUXOUT(0x7) | ADF4350_REG2_NOISE_MODE(0x9)));
>> + ADF4350_REG2_MUXOUT(0x7) | ADF4350_REG2_NOISE_MODE(0x3)));
>>
>> st->regs[ADF4350_REG3] = pdata->r3_user_settings &
>> (ADF4350_REG3_12BIT_CLKDIV(0xFFF) |
>>
--
Greetings,
Michael
--
Analog Devices GmbH Wilhelm-Wagenfeld-Str. 6 80807 Muenchen
Sitz der Gesellschaft: Muenchen; Registergericht: Muenchen HRB 40368;
Geschaeftsfuehrer:Dr.Carsten Suckrow, Thomas Wessel, William A. Martin,
Margaret Seif
prev parent reply other threads:[~2013-06-03 8:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-23 15:00 [PATCH 1/4] iio: frequency: ad4350: Fix bug / typo in mask michael.hennerich
2013-05-23 15:00 ` [PATCH 2/4] iio: frequency: adf4350: cast value to unsigned to make code checkers happy michael.hennerich
2013-05-23 15:00 ` [PATCH 3/4] iio: frequency: adf4350: Add support for clock consumer framework michael.hennerich
2013-05-23 15:00 ` [PATCH 4/4] iio: frequency: adf4350: Add support for dt bindings michael.hennerich
2013-05-23 16:45 ` Lars-Peter Clausen
2013-05-27 11:28 ` Michael Hennerich
2013-06-02 16:10 ` [PATCH 1/4] iio: frequency: ad4350: Fix bug / typo in mask Jonathan Cameron
2013-06-03 8:20 ` Michael Hennerich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51AC51E6.80108@analog.com \
--to=michael.hennerich@analog.com \
--cc=dan.carpenter@oracle.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).