From: Lars-Peter Clausen <lars@metafoo.de>
To: michael.hennerich@analog.com
Cc: jic23@kernel.org, linux-iio@vger.kernel.org,
Lars-Peter.Clausen@analog.com, dan.carpenter@oracle.com
Subject: Re: [PATCH RESEND V2 1/4] iio: frequency: ad4350: Fix bug / typo in mask
Date: Tue, 04 Jun 2013 15:57:50 +0200 [thread overview]
Message-ID: <51ADF25E.3050701@metafoo.de> (raw)
In-Reply-To: <1370266249-26338-1-git-send-email-michael.hennerich@analog.com>
On 06/03/2013 03:30 PM, michael.hennerich@analog.com wrote:
> From: Michael Hennerich <michael.hennerich@analog.com>
> t
> Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>me.
FWIW, complete series looks good to. All four patches:
Reviewed-by: Lars-Peter Clausen <lars@metafoo.de>
> ---
> drivers/iio/frequency/adf4350.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/frequency/adf4350.c b/drivers/iio/frequency/adf4350.c
> index a884252..e76d4ac 100644
> --- a/drivers/iio/frequency/adf4350.c
> +++ b/drivers/iio/frequency/adf4350.c
> @@ -212,7 +212,7 @@ static int adf4350_set_freq(struct adf4350_state *st, unsigned long long freq)
> (pdata->r2_user_settings & (ADF4350_REG2_PD_POLARITY_POS |
> ADF4350_REG2_LDP_6ns | ADF4350_REG2_LDF_INT_N |
> ADF4350_REG2_CHARGE_PUMP_CURR_uA(5000) |
> - ADF4350_REG2_MUXOUT(0x7) | ADF4350_REG2_NOISE_MODE(0x9)));
> + ADF4350_REG2_MUXOUT(0x7) | ADF4350_REG2_NOISE_MODE(0x3)));
>
> st->regs[ADF4350_REG3] = pdata->r3_user_settings &
> (ADF4350_REG3_12BIT_CLKDIV(0xFFF) |
next prev parent reply other threads:[~2013-06-04 14:05 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-03 13:30 [PATCH RESEND V2 1/4] iio: frequency: ad4350: Fix bug / typo in mask michael.hennerich
2013-06-03 13:30 ` [PATCH RESEND V2 2/4] iio: frequency: adf4350: cast value to unsigned to make code checkers happy michael.hennerich
2013-06-04 18:03 ` Jonathan Cameron
2013-06-03 13:30 ` [PATCH RESEND V2 3/4] iio: frequency: adf4350: Add support for clock consumer framework michael.hennerich
2013-06-04 17:44 ` Jonathan Cameron
2013-06-05 7:32 ` Michael Hennerich
2013-06-05 14:25 ` Lars-Peter Clausen
2013-06-05 15:25 ` Jonathan Cameron
2013-06-05 17:34 ` Lars-Peter Clausen
2013-06-05 17:43 ` Jonathan Cameron
2013-06-05 18:07 ` Lars-Peter Clausen
2013-06-05 20:18 ` Jonathan Cameron
2013-06-06 14:41 ` Lars-Peter Clausen
2013-06-08 8:58 ` Jonathan Cameron
2013-06-09 18:17 ` Jonathan Cameron
2013-06-03 13:30 ` [PATCH RESEND V2 4/4] iio: frequency: adf4350: Add support for dt bindings michael.hennerich
2013-06-09 18:16 ` Jonathan Cameron
2013-06-04 13:57 ` Lars-Peter Clausen [this message]
2013-06-04 17:36 ` [PATCH RESEND V2 1/4] iio: frequency: ad4350: Fix bug / typo in mask Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51ADF25E.3050701@metafoo.de \
--to=lars@metafoo.de \
--cc=Lars-Peter.Clausen@analog.com \
--cc=dan.carpenter@oracle.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=michael.hennerich@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).