From: Jonathan Cameron <jic23@kernel.org>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: linux-iio@vger.kernel.org, mirq-linux@rere.qmqm.pl
Subject: Re: [PATCH 0/4 V2] iio: Rework the generic trigger-gpio trigger and move out of staging
Date: Tue, 04 Jun 2013 18:28:01 +0100 [thread overview]
Message-ID: <51AE23A1.2050401@kernel.org> (raw)
In-Reply-To: <51ADF315.1060108@metafoo.de>
On 06/04/2013 03:00 PM, Lars-Peter Clausen wrote:
> On 06/02/2013 09:00 PM, Jonathan Cameron wrote:
>> Only changes here are dropping the irq_res_cnt as it unused (thanks Lars) and
>> a rebase as a result of some Kconfig dependency changes.
>>
>> I still don't have a hardware setup, but this is so simple that unless
>> someone shouts I'll probably send it upstream in fairly soon anyway.
>>
>> Jonathan
>>
>> Previous message:
>>
>> Hi all,
>>
>> This is an RFC for a couple of reasons.
>>
>> 1) I'm not sure how people feel about the move to multiple platform devices
>> (patch 3).
>> 2) I don't actually have a simple test setup for this one. I can put one
>> together but it might be a while before I get it done.
>>
>> Anyhow, the purpose of this set is to respond to Lars-Peter's comments
>> when I originally asked if anyone minded it moving out of staging as it
>> was before this. Lars raised the point that having one driver instance
>> register multiple triggers just made life more complicated, and instead
>> it might be better to have multiple driver instances, with one trigger each.
>> Lars also pointed out that the name of the driver was silly given there
>> was nolonger a requirement that the source of the interrupts be a gpio
>> and there hasn't been for quite some time.
>>
>> All comments welcome. Particularly wrt to patch 3.
>
> Looks all good to me. FWIW:
>
> Reviewed-by: Lars-Peter Clausen <lars@metafoo.de>
>
Thanks, gives me a warm fuzzy feeling. I hate merging
my own patches unreviewed!
Will apply these to the togreg branch of iio.git in a few mins.
>>
>> Jonathan Cameron (4):
>> staging:iio:trigger:gpio bug in release of gpio in error path
>> staging:iio:triggers: rename iio-trig-gpio to iio-trig-interrupt
>> staging:iio:triggers:interrupt trigger - one per platform device.
>> iio:triggers:interrupt trigger - move out of staging.
>>
>> drivers/iio/trigger/Kconfig | 9 ++
>> drivers/iio/trigger/Makefile | 1 +
>> drivers/iio/trigger/iio-trig-interrupt.c | 121 ++++++++++++++++++++
>> drivers/staging/iio/trigger/Kconfig | 6 -
>> drivers/staging/iio/trigger/Makefile | 1 -
>> drivers/staging/iio/trigger/iio-trig-gpio.c | 167 ----------------------------
>> 6 files changed, 131 insertions(+), 174 deletions(-)
>> create mode 100644 drivers/iio/trigger/iio-trig-interrupt.c
>> delete mode 100644 drivers/staging/iio/trigger/iio-trig-gpio.c
>>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
prev parent reply other threads:[~2013-06-04 17:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-02 19:00 [PATCH 0/4 V2] iio: Rework the generic trigger-gpio trigger and move out of staging Jonathan Cameron
2013-06-02 19:00 ` [PATCH 1/4] staging:iio:trigger:gpio bug in release of gpio in error path Jonathan Cameron
2013-06-02 19:00 ` [PATCH 2/4] staging:iio:triggers: rename iio-trig-gpio to iio-trig-interrupt Jonathan Cameron
2013-06-02 19:00 ` [PATCH 3/4] staging:iio:triggers:interrupt trigger - one per platform device Jonathan Cameron
2013-06-02 19:00 ` [PATCH 4/4] iio:triggers:interrupt trigger - move out of staging Jonathan Cameron
2013-06-04 14:00 ` [PATCH 0/4 V2] iio: Rework the generic trigger-gpio trigger and " Lars-Peter Clausen
2013-06-04 17:28 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51AE23A1.2050401@kernel.org \
--to=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=mirq-linux@rere.qmqm.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).