* [PATCH] iio:trigger:interrupt fix formatting of rsize variable in name
@ 2013-06-06 18:24 Jonathan Cameron
2013-06-06 18:26 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Jonathan Cameron @ 2013-06-06 18:24 UTC (permalink / raw)
To: linux-iio; +Cc: lars, kbuild-all, Fengguang Wu, Jonathan Cameron
The name includes irq_res->start which of type resource_size_t not integer.
We could in theory use %pa for this but then it would be in hex and also
that causes a warning about incorrect types anyway. Hence just
use the irq local variable we assigned the line above.
Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
---
drivers/iio/trigger/iio-trig-interrupt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/trigger/iio-trig-interrupt.c b/drivers/iio/trigger/iio-trig-interrupt.c
index 84bf397..0a6756d 100644
--- a/drivers/iio/trigger/iio-trig-interrupt.c
+++ b/drivers/iio/trigger/iio-trig-interrupt.c
@@ -50,7 +50,7 @@ static int iio_interrupt_trigger_probe(struct platform_device *pdev)
irq = irq_res->start;
- trig = iio_trigger_alloc("irqtrig%d", irq_res->start);
+ trig = iio_trigger_alloc("irqtrig%zu", irq_res->start);
if (!trig) {
ret = -ENOMEM;
goto error_ret;
--
1.8.3
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] iio:trigger:interrupt fix formatting of rsize variable in name
2013-06-06 18:24 [PATCH] iio:trigger:interrupt fix formatting of rsize variable in name Jonathan Cameron
@ 2013-06-06 18:26 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2013-06-06 18:26 UTC (permalink / raw)
To: Jonathan Cameron; +Cc: linux-iio, lars, kbuild-all, Fengguang Wu
On 06/06/2013 07:24 PM, Jonathan Cameron wrote:
> The name includes irq_res->start which of type resource_size_t not integer.
> We could in theory use %pa for this but then it would be in hex and also
> that causes a warning about incorrect types anyway. Hence just
> use the irq local variable we assigned the line above.
>
Sorry, sent the wrong version out due to forgetting to update the commit.
> Reported-by: Fengguang Wu <fengguang.wu@intel.com>
> Signed-off-by: Jonathan Cameron <jic23@kernel.org>
> ---
> drivers/iio/trigger/iio-trig-interrupt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/trigger/iio-trig-interrupt.c b/drivers/iio/trigger/iio-trig-interrupt.c
> index 84bf397..0a6756d 100644
> --- a/drivers/iio/trigger/iio-trig-interrupt.c
> +++ b/drivers/iio/trigger/iio-trig-interrupt.c
> @@ -50,7 +50,7 @@ static int iio_interrupt_trigger_probe(struct platform_device *pdev)
>
> irq = irq_res->start;
>
> - trig = iio_trigger_alloc("irqtrig%d", irq_res->start);
> + trig = iio_trigger_alloc("irqtrig%zu", irq_res->start);
> if (!trig) {
> ret = -ENOMEM;
> goto error_ret;
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-06-06 18:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-06 18:24 [PATCH] iio:trigger:interrupt fix formatting of rsize variable in name Jonathan Cameron
2013-06-06 18:26 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).