Re: [PATCH 2/4] staging:iio:adis16130: Fix sample reading

[Jonathan Cameron <jic23@kernel.org>]

On 06/10/2013 03:00 PM, Lars-Peter Clausen wrote:
> The driver first does a proper read of the data register, but right after that
> it does a spi_read, which will overwrite the initial result.
> 
> It looks as if the extra spi_read was accidentally introduced in commit
> a5e7363ca ("staging:iio:gyro:adis16130 drop control of adc resolution."), quite
> likely due to a bad rebase.
> 
oops.  This is a rather old bug now so I'm not rushing this one out. It can
wait for the next merge cycle, at which point you might want to request it is
applied to the stable trees.
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Applied to the togreg branch of iio.git

> ---
>  drivers/staging/iio/gyro/adis16130_core.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/staging/iio/gyro/adis16130_core.c b/drivers/staging/iio/gyro/adis16130_core.c
> index 5288635..2537f59 100644
> --- a/drivers/staging/iio/gyro/adis16130_core.c
> +++ b/drivers/staging/iio/gyro/adis16130_core.c
> @@ -62,7 +62,6 @@ static int adis16130_spi_read(struct iio_dev *indio_dev, u8 reg_addr, u32 *val)
>  	spi_message_init(&msg);
>  	spi_message_add_tail(&xfer, &msg);
>  	ret = spi_sync(st->us, &msg);
> -	ret = spi_read(st->us, st->buf, 4);
>  
>  	if (ret == 0)
>  		*val = (st->buf[1] << 16) | (st->buf[2] << 8) | st->buf[3];
>