From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <51C5A1AF.3070404@free-electrons.com> Date: Sat, 22 Jun 2013 15:07:59 +0200 From: Alexandre Belloni MIME-Version: 1.0 To: Lars-Peter Clausen CC: Jonathan Cameron , Shawn Guo , Grant Likely , jimwall@q.com, brian@crystalfontz.com, Maxime Ripard , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree-discuss@lists.ozlabs.org, Jonathan Cameron , Rob Landley , Rob Herring Subject: Re: [PATCHv2 1/3] iio: Add Nuvoton NAU7802 ADC driver References: <1371754675-12242-1-git-send-email-alexandre.belloni@free-electrons.com> <1371754675-12242-2-git-send-email-alexandre.belloni@free-electrons.com> <51C590B5.2060308@kernel.org> <51C5923D.6030609@metafoo.de> In-Reply-To: <51C5923D.6030609@metafoo.de> Content-Type: text/plain; charset=ISO-8859-1 List-ID: On 22/06/2013 14:02, Lars-Peter Clausen wrote: > On 06/22/2013 01:55 PM, Jonathan Cameron wrote: >> On 06/20/2013 07:57 PM, Alexandre Belloni wrote: >>> The Nuvoton NAU7802 ADC is a 24-bit 2-channels I2C ADC, with adjustable >>> gain and sampling rates. >>> >> Sorry, somewhat low on time today so only a quick review. >> >> 1) Missing userspace ABI documentation. Also, perhaps min_conversions is >> a little vague? Not that I have a better idea! > I really don't like the name min_conversions either. Isn't this effectively > a decimation filter? Yeah, it could be seen like that but it is only relevant and only happens when switching between channels. I'm open to any ideas. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com