From: Jonathan Cameron <jic23@kernel.org>
To: Peter Meerwald <pmeerw@pmeerw.net>
Cc: linux-iio@vger.kernel.org, Ge Gao <ggao@invensense.com>
Subject: Re: [PATCH 2/5] iio: use I2C_FUNC_SMBUS_I2C_BLOCK macro
Date: Sat, 29 Jun 2013 10:51:06 +0100 [thread overview]
Message-ID: <51CEAE0A.1020800@kernel.org> (raw)
In-Reply-To: <1372022900-18670-2-git-send-email-pmeerw@pmeerw.net>
On 06/23/2013 10:28 PM, Peter Meerwald wrote:
> I do not see why the driver requires I2C_FUNC_SMBUS_I2C_BLOCK,
> actually only single bytes or words are transferred
Applied as is, but Ge, I would like you to answer Peter's question
about whether this is actually needed at all.
>
> Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
> Cc: Ge Gao <ggao@invensense.com>
> ---
> drivers/iio/imu/inv_mpu6050/inv_mpu_core.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
> index fe4c61e..6a1ff80 100644
> --- a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
> +++ b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
> @@ -663,8 +663,8 @@ static int inv_mpu_probe(struct i2c_client *client,
> int result;
>
> if (!i2c_check_functionality(client->adapter,
> - I2C_FUNC_SMBUS_READ_I2C_BLOCK |
> - I2C_FUNC_SMBUS_WRITE_I2C_BLOCK)) {
> + I2C_FUNC_SMBUS_I2C_BLOCK)) {
> +
> result = -ENOSYS;
> goto out_no_free;
> }
>
next prev parent reply other threads:[~2013-06-29 9:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-23 21:28 [PATCH 1/5] iio: fix typos in dac Kconfig Peter Meerwald
2013-06-23 21:28 ` [PATCH 2/5] iio: use I2C_FUNC_SMBUS_I2C_BLOCK macro Peter Meerwald
2013-06-29 9:51 ` Jonathan Cameron [this message]
2013-06-29 23:05 ` Ge Gao
2013-06-23 21:28 ` [PATCH 3/5] iio: fix Kconfig typos Peter Meerwald
2013-06-29 10:08 ` Jonathan Cameron
2013-06-23 21:28 ` [PATCH 4/5] iio: remove mention of ring buffer from CONFIG_IIO_KFIFO_BUF, CONFIG_IIO_TRIGGER description Peter Meerwald
2013-06-29 12:15 ` Jonathan Cameron
2013-06-23 21:28 ` [PATCH 5/5] iio: reword help text of several IIO_ST drivers Peter Meerwald
2013-06-24 6:30 ` Denis CIOCCA
2013-06-29 12:17 ` Jonathan Cameron
2013-06-24 6:18 ` [PATCH 1/5] iio: fix typos in dac Kconfig Lars-Peter Clausen
2013-06-29 9:49 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51CEAE0A.1020800@kernel.org \
--to=jic23@kernel.org \
--cc=ggao@invensense.com \
--cc=linux-iio@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox