From: Lars-Peter Clausen <lars@metafoo.de>
To: Hector Palacios <hector.palacios@digi.com>
Cc: linux-iio@vger.kernel.org, alexandre.belloni@free-electrons.com,
jic23@kernel.org, marex@denx.de, fabio.estevam@freescale.com
Subject: Re: [PATCH 3/4] iio: mxs-lradc: add scale_available file to channels
Date: Fri, 05 Jul 2013 12:40:02 +0200 [thread overview]
Message-ID: <51D6A282.4040506@metafoo.de> (raw)
In-Reply-To: <1373013039-19461-4-git-send-email-hector.palacios@digi.com>
On 07/05/2013 10:30 AM, Hector Palacios wrote:
[...]
> +#define SHOW_SCALE_AVAILABLE_FUNC(ch) \
> +static ssize_t mxs_lradc_show_scale_available##ch(struct device *dev, \
> + struct device_attribute *attr, \
> + char *buf) \
> +{ \
> + return c ch); \
> +}
No need for a separate function for each channel. Use the address attribute
of the iio_dev_attr. E.g.
struct iio_dev_attr *iio_attr = to_iio_dev_attr(attr);
return mxs_lradc_show_scale_available_ch(dev, attr, buf, iio_attr->address);
The last parameter to IIO_DEVICE_ATTR initializes this field.
But I think you can need less boilerplate code if you use the
iio_chan_spec_ext_info feature. Take a look at IIO_ENUM_AVAILABLE and
friends to see how it is done.
- Lars
next prev parent reply other threads:[~2013-07-05 10:39 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-05 8:30 [PATCH 0/4] iio: mxs-lradc: add support to optional divider_by_two Hector Palacios
2013-07-05 8:30 ` [PATCH 1/4] iio: mxs-lradc: change the realbits to 12 Hector Palacios
2013-07-05 11:37 ` Marek Vasut
2013-07-05 12:40 ` Hector Palacios
2013-07-05 13:10 ` Marek Vasut
2013-07-05 14:35 ` Hector Palacios
2013-07-05 17:17 ` Lars-Peter Clausen
2013-07-06 10:08 ` Jonathan Cameron
2013-07-06 10:13 ` Marek Vasut
2013-07-10 10:47 ` Hector Palacios
2013-07-10 11:49 ` Marek Vasut
2013-07-10 14:45 ` Hector Palacios
2013-07-10 15:22 ` Marek Vasut
2013-07-05 8:30 ` [PATCH 2/4] iio: mxs-lradc: add scale attribute to channels Hector Palacios
2013-07-05 10:32 ` Lars-Peter Clausen
2013-07-05 15:49 ` Hector Palacios
2013-07-05 16:56 ` Marek Vasut
2013-07-05 11:41 ` Marek Vasut
2013-07-05 16:42 ` Hector Palacios
2013-07-05 16:59 ` Marek Vasut
2013-07-05 17:08 ` Lars-Peter Clausen
2013-07-05 17:39 ` Marek Vasut
2013-07-06 9:59 ` Jonathan Cameron
2013-07-05 8:30 ` [PATCH 3/4] iio: mxs-lradc: add scale_available file " Hector Palacios
2013-07-05 10:40 ` Lars-Peter Clausen [this message]
2013-07-08 8:27 ` Hector Palacios
2013-07-08 8:42 ` Lars-Peter Clausen
2013-07-05 11:46 ` Marek Vasut
2013-07-08 8:51 ` Hector Palacios
2013-07-08 13:05 ` Marek Vasut
2013-07-05 8:30 ` [PATCH 4/4] iio: mxs-lradc: add write_raw function to modify scale Hector Palacios
2013-07-05 10:41 ` Lars-Peter Clausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51D6A282.4040506@metafoo.de \
--to=lars@metafoo.de \
--cc=alexandre.belloni@free-electrons.com \
--cc=fabio.estevam@freescale.com \
--cc=hector.palacios@digi.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=marex@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).