From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <51D6FDA7.5010301@metafoo.de> Date: Fri, 05 Jul 2013 19:08:55 +0200 From: Lars-Peter Clausen MIME-Version: 1.0 To: Marek Vasut CC: Hector Palacios , "linux-iio@vger.kernel.org" , "alexandre.belloni@free-electrons.com" , "jic23@kernel.org" , "fabio.estevam@freescale.com" Subject: Re: [PATCH 2/4] iio: mxs-lradc: add scale attribute to channels References: <1373013039-19461-1-git-send-email-hector.palacios@digi.com> <201307051341.35612.marex@denx.de> <51D6F78E.5080301@digi.com> <201307051859.01095.marex@denx.de> In-Reply-To: <201307051859.01095.marex@denx.de> Content-Type: text/plain; charset=ISO-8859-1 List-ID: On 07/05/2013 06:59 PM, Marek Vasut wrote: [...] >>> Should the above not be in DT ? >> >> Do you mean for example: >> >> lradc@80050000 { >> compatible = "fsl,imx28-lradc"; >> reg = <0x80050000 0x2000>; >> interrupts = <10 14 15 16 17 18 19 >> 20 21 22 23 24 25>; >> vref = <1850 1850 1850 1850 >> 1850 1850 1850 7400 >> 1850 1850 3700 1850 >> 3700 1850 1850 7400> >> }; >> >> I'm ok with it, but are there other examples of driver using a similar >> approach? I see for example the spear-adc which reads: >> >> Optional properties: >> - vref-external: External voltage reference in milli-volts. If omitted >> the internal voltage reference will be used. >> >> which makes me believe the 'internal voltage reference' is hardcoded in the >> driver. More opinions? > > I'd duke this one out on devicetree-discuss@ list. In general, I'd use something > like fsl,vref prop, but this really better be discussed in a separate thread. > > On the other hand, I'd hate to keep these patches here waiting , so maybe we > should apply them as-is and remove this part from the driver in a subsequent > patch? What do you say, Lars ? I'd leave it as it is. I don't see much point in putting them into the devicetree, it would have made sense if the scales were board specific. - Lars