[PATCH V2] iio: mxs-lradc: Remove useless check in read_raw

[PATCH V2] iio: mxs-lradc: Remove useless check in read_raw

[Marek Vasut]

The removed check in the read_raw implementation was always true,
therefore remove it. This also fixes a bug, by closely inspecting
the code, one can notice the iio_validate_scan_mask_onehot() will
always return 1 and therefore the subsequent condition will always
succeed, therefore making the mxs_lradc_read_raw() function always
return -EINVAL; .

Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Jonathan Cameron <jic23@kernel.org>
Cc: Fabio Estevam <fabio.estevam@freescale.com>
---
 drivers/staging/iio/adc/mxs-lradc.c |    7 -------
 1 file changed, 7 deletions(-)

V2: Update the patch description, by discussion on the ML, we found
    out this accidentally fixes a bug.

diff --git a/drivers/staging/iio/adc/mxs-lradc.c b/drivers/staging/iio/adc/mxs-lradc.c
index d92c97a..c318eb6 100644
--- a/drivers/staging/iio/adc/mxs-lradc.c
+++ b/drivers/staging/iio/adc/mxs-lradc.c
@@ -234,7 +234,6 @@ static int mxs_lradc_read_raw(struct iio_dev *iio_dev,
 {
 	struct mxs_lradc *lradc = iio_priv(iio_dev);
 	int ret;
-	unsigned long mask;
 
 	if (m != IIO_CHAN_INFO_RAW)
 		return -EINVAL;
@@ -243,12 +242,6 @@ static int mxs_lradc_read_raw(struct iio_dev *iio_dev,
 	if (chan->channel > LRADC_MAX_TOTAL_CHANS)
 		return -EINVAL;
 
-	/* Validate the channel if it doesn't intersect with reserved chans. */
-	bitmap_set(&mask, chan->channel, 1);
-	ret = iio_validate_scan_mask_onehot(iio_dev, &mask);
-	if (ret)
-		return -EINVAL;
-
 	/*
 	 * See if there is no buffered operation in progess. If there is, simply
 	 * bail out. This can be improved to support both buffered and raw IO at
-- 
1.7.10.4

Re: [PATCH V2] iio: mxs-lradc: Remove useless check in read_raw

[Otavio Salvador]

On Wed, Jul 3, 2013 at 6:25 PM, Marek Vasut <marex@denx.de> wrote:
> The removed check in the read_raw implementation was always true,
> therefore remove it. This also fixes a bug, by closely inspecting
> the code, one can notice the iio_validate_scan_mask_onehot() will
> always return 1 and therefore the subsequent condition will always
> succeed, therefore making the mxs_lradc_read_raw() function always
> return -EINVAL; .
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Jonathan Cameron <jic23@kernel.org>
> Cc: Fabio Estevam <fabio.estevam@freescale.com>

Tested-by: Otavio Salvador <otavio@ossystems.com.br>

--
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://projetos.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

Re: [PATCH V2] iio: mxs-lradc: Remove useless check in read_raw

[Hector Palacios]

On 07/04/2013 10:22 PM, Otavio Salvador wrote:
> On Wed, Jul 3, 2013 at 6:25 PM, Marek Vasut <marex-ynQEQJNshbs@public.gmane.org> wrote:
>> The removed check in the read_raw implementation was always true,
>> therefore remove it. This also fixes a bug, by closely inspecting
>> the code, one can notice the iio_validate_scan_mask_onehot() will
>> always return 1 and therefore the subsequent condition will always
>> succeed, therefore making the mxs_lradc_read_raw() function always
>> return -EINVAL; .
>>
>> Signed-off-by: Marek Vasut <marex-ynQEQJNshbs@public.gmane.org>
>> Cc: Jonathan Cameron <jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
>> Cc: Fabio Estevam <fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
>
> Tested-by: Otavio Salvador <otavio-fKevB0iiKLMBZ+LybsDmbA@public.gmane.org>

Acked-by: Hector Palacios <hector.palacios@digi.com>


Best regards,
--
Hector Palacios

Re: [PATCH V2] iio: mxs-lradc: Remove useless check in read_raw

[Jonathan Cameron]

On 07/03/2013 10:25 PM, Marek Vasut wrote:
> The removed check in the read_raw implementation was always true,
> therefore remove it. This also fixes a bug, by closely inspecting
> the code, one can notice the iio_validate_scan_mask_onehot() will
> always return 1 and therefore the subsequent condition will always
> succeed, therefore making the mxs_lradc_read_raw() function always
> return -EINVAL; .
> 
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Jonathan Cameron <jic23@kernel.org>
> Cc: Fabio Estevam <fabio.estevam@freescale.com>
Applied to the fixes-togreg branch of iio.git.

Thanks,
> ---
>  drivers/staging/iio/adc/mxs-lradc.c |    7 -------
>  1 file changed, 7 deletions(-)
> 
> V2: Update the patch description, by discussion on the ML, we found
>     out this accidentally fixes a bug.
> 
> diff --git a/drivers/staging/iio/adc/mxs-lradc.c b/drivers/staging/iio/adc/mxs-lradc.c
> index d92c97a..c318eb6 100644
> --- a/drivers/staging/iio/adc/mxs-lradc.c
> +++ b/drivers/staging/iio/adc/mxs-lradc.c
> @@ -234,7 +234,6 @@ static int mxs_lradc_read_raw(struct iio_dev *iio_dev,
>  {
>  	struct mxs_lradc *lradc = iio_priv(iio_dev);
>  	int ret;
> -	unsigned long mask;
>  
>  	if (m != IIO_CHAN_INFO_RAW)
>  		return -EINVAL;
> @@ -243,12 +242,6 @@ static int mxs_lradc_read_raw(struct iio_dev *iio_dev,
>  	if (chan->channel > LRADC_MAX_TOTAL_CHANS)
>  		return -EINVAL;
>  
> -	/* Validate the channel if it doesn't intersect with reserved chans. */
> -	bitmap_set(&mask, chan->channel, 1);
> -	ret = iio_validate_scan_mask_onehot(iio_dev, &mask);
> -	if (ret)
> -		return -EINVAL;
> -
>  	/*
>  	 * See if there is no buffered operation in progess. If there is, simply
>  	 * bail out. This can be improved to support both buffered and raw IO at
>