From: Jonathan Cameron <jic23@kernel.org>
To: Wei Yongjun <weiyj.lk@gmail.com>
Cc: jic23@cam.ac.uk, gregkh@linuxfoundation.org, lars@metafoo.de,
wfp5p@virginia.edu, yongjun_wei@trendmicro.com.cn,
linux-iio@vger.kernel.org, devel@driverdev.osuosl.org
Subject: Re: [PATCH] staging:iio:ad7291: add missing .driver_module to struct iio_info
Date: Sat, 06 Jul 2013 10:40:57 +0100 [thread overview]
Message-ID: <51D7E629.8000603@kernel.org> (raw)
In-Reply-To: <CAPgLHd-v0MJWgtjY66Ky87ieQYxXg_9bFQxB0N5zoibshCV7Jg@mail.gmail.com>
On 07/04/2013 02:46 PM, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Add missing .driver_module of struct iio_info. This prevents the
> module from being removed from underneath its users.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Applied to the fixes-togreg branch of iio.git.
Obviously we want this fix whatever the outcome of the discussion started
by Greg as any changes will be in the next cycle, not this one.
Thanks,
Jonathan
> ---
> drivers/staging/iio/adc/ad7291.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/iio/adc/ad7291.c b/drivers/staging/iio/adc/ad7291.c
> index 3fc79e5..a2e61c2 100644
> --- a/drivers/staging/iio/adc/ad7291.c
> +++ b/drivers/staging/iio/adc/ad7291.c
> @@ -517,6 +517,7 @@ static const struct iio_info ad7291_info = {
> .read_event_value = &ad7291_read_event_value,
> .write_event_value = &ad7291_write_event_value,
> .event_attrs = &ad7291_event_attribute_group,
> + .driver_module = THIS_MODULE,
> };
>
> static int ad7291_probe(struct i2c_client *client,
>
prev parent reply other threads:[~2013-07-06 9:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-04 13:46 [PATCH] staging:iio:ad7291: add missing .driver_module to struct iio_info Wei Yongjun
2013-07-04 16:01 ` Greg KH
2013-07-05 9:55 ` Lars-Peter Clausen
2013-07-05 13:10 ` Wei Yongjun
2013-07-06 9:40 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51D7E629.8000603@kernel.org \
--to=jic23@kernel.org \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@cam.ac.uk \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=weiyj.lk@gmail.com \
--cc=wfp5p@virginia.edu \
--cc=yongjun_wei@trendmicro.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).