From: Jonathan Cameron <jic23@kernel.org>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Oleksandr Kravchenko <o.v.kravchenko@globallogic.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
arnd@arndb.de, jic23@cam.ac.uk
Subject: Re: Issue with porting i2c driver to k3.10 (iio)
Date: Sat, 06 Jul 2013 12:47:08 +0100 [thread overview]
Message-ID: <51D803BC.8000403@kernel.org> (raw)
In-Reply-To: <20130704161911.GC20907@kroah.com>
On 07/04/2013 05:19 PM, Greg KH wrote:
> On Thu, Jul 04, 2013 at 04:16:43PM +0300, Oleksandr Kravchenko wrote:
>> Hi All,
>>
>> I wrote i2c driver for APDS-9300 light sensor in drivers/misc, but I have some
>> questions regarding upstreaming of it.
>> 1. It works properly in kernel-3.4, but it works very slow in kernel-3.10 (on
>> mutex and i2c operations, particulary on mutex_lock() and i2c_smbus_read_data
>> ()). Does anyone know why this issue may be occurred?
>
> What is "slow"? Have you run 'perf' on the driver to see where it is
> spending time?
>
>> 2. Can I send this driver without using Industrial I/O framework?
>
> No, why would you even want to?
Looks like a fairly standard light sensor so drivers/iio/light.
Actually very close in design to some of the TAOS parts such as those supported
by the tsl2563 driver if you want a reference driver to compare with.
Jonathan
prev parent reply other threads:[~2013-07-06 11:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-04 13:16 Issue with porting i2c driver to k3.10 (iio) Oleksandr Kravchenko
2013-07-04 16:19 ` Greg KH
2013-07-06 11:47 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51D803BC.8000403@kernel.org \
--to=jic23@kernel.org \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@cam.ac.uk \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=o.v.kravchenko@globallogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).