* Issue with porting i2c driver to k3.10 (iio)
@ 2013-07-04 13:16 Oleksandr Kravchenko
2013-07-04 16:19 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Oleksandr Kravchenko @ 2013-07-04 13:16 UTC (permalink / raw)
To: linux-iio, linux-kernel; +Cc: arnd, gregkh, jic23
[-- Attachment #1: Type: text/plain, Size: 590 bytes --]
Hi All,
I wrote i2c driver for APDS-9300 light sensor in drivers/misc, but I have
some questions regarding upstreaming of it.
1. It works properly in kernel-3.4, but it works very slow in kernel-3.10
(on mutex and i2c operations, particulary on mutex_lock() and
i2c_smbus_read_data()). Does anyone know why this issue may be occurred?
2. Can I send this driver without using Industrial I/O framework?
Thanks in advance.
--
Oleksandr Kravchenko
GlobalLogic
P +380633213187
P +380994930248
www.globallogic.com
<http://www.globallogic.com/>
http://www.globallogic.com/email_disclaimer.txt
[-- Attachment #2: Type: text/html, Size: 2958 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Issue with porting i2c driver to k3.10 (iio)
2013-07-04 13:16 Issue with porting i2c driver to k3.10 (iio) Oleksandr Kravchenko
@ 2013-07-04 16:19 ` Greg KH
2013-07-06 11:47 ` Jonathan Cameron
0 siblings, 1 reply; 3+ messages in thread
From: Greg KH @ 2013-07-04 16:19 UTC (permalink / raw)
To: Oleksandr Kravchenko; +Cc: linux-iio, linux-kernel, arnd, jic23
On Thu, Jul 04, 2013 at 04:16:43PM +0300, Oleksandr Kravchenko wrote:
> Hi All,
>
> I wrote i2c driver for APDS-9300 light sensor in drivers/misc, but I have some
> questions regarding upstreaming of it.
> 1. It works properly in kernel-3.4, but it works very slow in kernel-3.10 (on
> mutex and i2c operations, particulary on mutex_lock() and i2c_smbus_read_data
> ()). Does anyone know why this issue may be occurred?
What is "slow"? Have you run 'perf' on the driver to see where it is
spending time?
> 2. Can I send this driver without using Industrial I/O framework?
No, why would you even want to?
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Issue with porting i2c driver to k3.10 (iio)
2013-07-04 16:19 ` Greg KH
@ 2013-07-06 11:47 ` Jonathan Cameron
0 siblings, 0 replies; 3+ messages in thread
From: Jonathan Cameron @ 2013-07-06 11:47 UTC (permalink / raw)
To: Greg KH; +Cc: Oleksandr Kravchenko, linux-iio, linux-kernel, arnd, jic23
On 07/04/2013 05:19 PM, Greg KH wrote:
> On Thu, Jul 04, 2013 at 04:16:43PM +0300, Oleksandr Kravchenko wrote:
>> Hi All,
>>
>> I wrote i2c driver for APDS-9300 light sensor in drivers/misc, but I have some
>> questions regarding upstreaming of it.
>> 1. It works properly in kernel-3.4, but it works very slow in kernel-3.10 (on
>> mutex and i2c operations, particulary on mutex_lock() and i2c_smbus_read_data
>> ()). Does anyone know why this issue may be occurred?
>
> What is "slow"? Have you run 'perf' on the driver to see where it is
> spending time?
>
>> 2. Can I send this driver without using Industrial I/O framework?
>
> No, why would you even want to?
Looks like a fairly standard light sensor so drivers/iio/light.
Actually very close in design to some of the TAOS parts such as those supported
by the tsl2563 driver if you want a reference driver to compare with.
Jonathan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-07-06 11:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-04 13:16 Issue with porting i2c driver to k3.10 (iio) Oleksandr Kravchenko
2013-07-04 16:19 ` Greg KH
2013-07-06 11:47 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).