From: Jonathan Cameron <jic23@kernel.org>
To: Peter Meerwald <pmeerw@pmeerw.net>
Cc: linux-iio@vger.kernel.org
Subject: Re: [PATCH 4/5] iio staging: fix lis3l02dq, read error handling
Date: Tue, 09 Jul 2013 22:14:07 +0100 [thread overview]
Message-ID: <51DC7D1F.3060901@kernel.org> (raw)
In-Reply-To: <1373228646-5356-4-git-send-email-pmeerw@pmeerw.net>
On 07/07/2013 09:24 PM, Peter Meerwald wrote:
> Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
Applied to the fixes-togreg branch of iio.git
Peter, just as an aside please separate out actual code
fixes like this one into separate series from the comment typo fixes.
Whilst both are worthwhile, comment typos can always wait for the
next merge window, but code fixes want to go in asap and perhaps
back into stable.
> ---
> drivers/staging/iio/accel/lis3l02dq_core.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/staging/iio/accel/lis3l02dq_core.c b/drivers/staging/iio/accel/lis3l02dq_core.c
> index 1bfe5d8..8ed75a9 100644
> --- a/drivers/staging/iio/accel/lis3l02dq_core.c
> +++ b/drivers/staging/iio/accel/lis3l02dq_core.c
> @@ -257,6 +257,8 @@ static int lis3l02dq_read_raw(struct iio_dev *indio_dev,
> ret = lis3l02dq_read_reg_s16(indio_dev, reg, val);
> }
> mutex_unlock(&indio_dev->mlock);
> + if (ret < 0)
> + goto error_ret;
> return IIO_VAL_INT;
> case IIO_CHAN_INFO_SCALE:
> *val = 0;
>
next prev parent reply other threads:[~2013-07-09 21:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-07 20:24 [PATCH 1/5] iio: staging: fix device.txt documentation Peter Meerwald
2013-07-07 20:24 ` [PATCH 2/5] iio: fix typo, Documentation/ABI/testing/sysfs-bus-iio-frequency-adf4350 Peter Meerwald
2013-07-09 21:15 ` Jonathan Cameron
2013-07-07 20:24 ` [PATCH 3/5] iio: staging: fix typo in ade758_ring.c Peter Meerwald
2013-07-09 21:15 ` Jonathan Cameron
2013-07-07 20:24 ` [PATCH 4/5] iio staging: fix lis3l02dq, read error handling Peter Meerwald
2013-07-09 21:14 ` Jonathan Cameron [this message]
2013-07-07 20:24 ` [PATCH 5/5] iio: fix semicolon in io_core_trigger.h Peter Meerwald
2013-07-09 21:16 ` Jonathan Cameron
2013-07-09 21:15 ` [PATCH 1/5] iio: staging: fix device.txt documentation Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51DC7D1F.3060901@kernel.org \
--to=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).