From: Alexander Holler <holler@ahsoftware.de>
To: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
Jonathan Cameron <jic23@cam.ac.uk>,
Srinivas Pandruvada <srinivas.pandruvada@intel.com>
Subject: Re: [PATCH 0/4] iio: hid-sensor: add module alias for autoload
Date: Fri, 12 Jul 2013 09:21:41 +0200 [thread overview]
Message-ID: <51DFAE85.9060508@ahsoftware.de> (raw)
In-Reply-To: <51DEEAFE.506@linux.intel.com>
Am 11.07.2013 19:27, schrieb Srinivas Pandruvada:
>
>
> On 07/10/2013 08:58 AM, Alexander Holler wrote:
>> Am 10.07.2013 17:27, schrieb Srinivas Pandruvada:
>>> Hi,
>>>
>>> There was no intention to prevent auto loading. Did you get chance to
>>> test these changes?
>>
>> Sure, I always test patches before I send them out.
>>
>> Ok, I haven't tested the changes with the iio HID drivers (I don't
>> have any commercial HID sensor hub, so I've just compile tested these
>> patches here, double reading them), but I've tested the similiar
>> changes with a patch for rtc-hid-sensor-time I've send out yesterday.
>> (sorry, no link, lkml.org seems dead, just search for
>> "rtc-hid-sensor-time: add module alias")
>>
>> It works just fine. An example output is now
>>
>> Jul 9 19:27:21 dockstar3 kernel: [ 5.124444] rtc_hid_sensor_time
>> HID-SENSOR-2000a0.0: milliseconds supported
>> Jul 9 19:27:21 dockstar3 kernel: [ 5.132864] rtc_hid_sensor_time
>> HID-SENSOR-2000a0.0: rtc core: setting system clock to 2013-07-09
>> 17:26:51:328000 UTC (1373390811)
>> Jul 9 19:27:21 dockstar3 kernel: [ 5.146105] rtc_hid_sensor_time
>> HID-SENSOR-2000a0.0: rtc core: registered hid-sensor-time as rtc0
>>
>> Before the output was e.g.
>>
>> HID-SENSOR-2000a0 HID-SENSOR-2000a0.0: rtc core: registered
>> hid-sensor-time as rtc0
>>
>> instead of the above with the descriptive rtc_hid_sensor_time.
> <Agreed. This is better. >
>> Automatic loading of modules works too and it works on ARM, Intel and
>> AMD as module or static linked. ;)
Do you have tested the patches with a real device? I assume you have one. ;)
Regards,
Alexander Holler
next prev parent reply other threads:[~2013-07-12 7:22 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-10 8:31 [PATCH 0/4] iio: hid-sensor: add module alias for autoload Alexander Holler
2013-07-10 8:31 ` [PATCH 1/4] iio: hid-sensor-accel-3d: " Alexander Holler
2013-07-10 8:31 ` [PATCH 2/4] iio: hid-sensor-gyro-3d: " Alexander Holler
2013-07-12 21:49 ` Srinivas Pandruvada
2013-07-10 8:31 ` [PATCH 3/4] iio: hid-sensor-als: " Alexander Holler
2013-07-12 21:49 ` Srinivas Pandruvada
2013-07-10 8:32 ` [PATCH 4/4] iio: hid-sensor-magn-3d: " Alexander Holler
2013-07-12 21:49 ` Srinivas Pandruvada
2013-07-10 15:27 ` [PATCH 0/4] iio: hid-sensor: " Srinivas Pandruvada
2013-07-10 15:58 ` Alexander Holler
2013-07-11 17:27 ` Srinivas Pandruvada
2013-07-12 7:21 ` Alexander Holler [this message]
2013-07-12 18:44 ` Jonathan Cameron
2013-07-12 18:46 ` Pandruvada, Srinivas
2013-07-12 21:46 ` Pandruvada, Srinivas
2013-07-13 13:29 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51DFAE85.9060508@ahsoftware.de \
--to=holler@ahsoftware.de \
--cc=jic23@cam.ac.uk \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=srinivas.pandruvada@intel.com \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).