From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from saturn.retrosnub.co.uk ([178.18.118.26]:47759 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932698Ab3GPQ4s (ORCPT ); Tue, 16 Jul 2013 12:56:48 -0400 Message-ID: <51E57B4F.5010201@kernel.org> Date: Tue, 16 Jul 2013 17:56:47 +0100 From: Jonathan Cameron MIME-Version: 1.0 To: Lars-Peter Clausen CC: Jonathan Cameron , linux-iio@vger.kernel.org Subject: Re: [PATCH 1/4] staging:iio:ad2s1210: Don't expose the chip reset to userspace References: <1373987283-32657-1-git-send-email-lars@metafoo.de> In-Reply-To: <1373987283-32657-1-git-send-email-lars@metafoo.de> Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org On 07/16/2013 04:08 PM, Lars-Peter Clausen wrote: > There is no reason why userspace should want to trigger a manual reset of the > device, so remove this functionality. > > Signed-off-by: Lars-Peter Clausen applied to the togreg branch of iio.git Thanks > --- > drivers/staging/iio/resolver/ad2s1210.c | 18 ------------------ > 1 file changed, 18 deletions(-) > > diff --git a/drivers/staging/iio/resolver/ad2s1210.c b/drivers/staging/iio/resolver/ad2s1210.c > index 0d3356d..dcdadbb 100644 > --- a/drivers/staging/iio/resolver/ad2s1210.c > +++ b/drivers/staging/iio/resolver/ad2s1210.c > @@ -192,21 +192,6 @@ static inline int ad2s1210_soft_reset(struct ad2s1210_state *st) > return ad2s1210_config_write(st, 0x0); > } > > -static ssize_t ad2s1210_store_softreset(struct device *dev, > - struct device_attribute *attr, > - const char *buf, > - size_t len) > -{ > - struct ad2s1210_state *st = iio_priv(dev_to_iio_dev(dev)); > - int ret; > - > - mutex_lock(&st->lock); > - ret = ad2s1210_soft_reset(st); > - mutex_unlock(&st->lock); > - > - return ret < 0 ? ret : len; > -} > - > static ssize_t ad2s1210_show_fclkin(struct device *dev, > struct device_attribute *attr, > char *buf) > @@ -536,8 +521,6 @@ error_ret: > return ret; > } > > -static IIO_DEVICE_ATTR(reset, S_IWUSR, > - NULL, ad2s1210_store_softreset, 0); > static IIO_DEVICE_ATTR(fclkin, S_IRUGO | S_IWUSR, > ad2s1210_show_fclkin, ad2s1210_store_fclkin, 0); > static IIO_DEVICE_ATTR(fexcit, S_IRUGO | S_IWUSR, > @@ -587,7 +570,6 @@ static const struct iio_chan_spec ad2s1210_channels[] = { > }; > > static struct attribute *ad2s1210_attributes[] = { > - &iio_dev_attr_reset.dev_attr.attr, > &iio_dev_attr_fclkin.dev_attr.attr, > &iio_dev_attr_fexcit.dev_attr.attr, > &iio_dev_attr_control.dev_attr.attr, >