From: Jonathan Cameron <jic23@kernel.org>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Jonathan Cameron <jic23@cam.ac.uk>, linux-iio@vger.kernel.org
Subject: Re: [PATCH 4/4] iio: Remove IIO_DEV_ATTR_RESET macro
Date: Tue, 16 Jul 2013 17:57:57 +0100 [thread overview]
Message-ID: <51E57B95.1090909@kernel.org> (raw)
In-Reply-To: <1373987283-32657-4-git-send-email-lars@metafoo.de>
On 07/16/2013 04:08 PM, Lars-Peter Clausen wrote:
> There are no users of this macro left and we have come to the conclusion that it
> is not a good idea to expose the raw chip reset to userspace so the macro is
> very unlikely to be used in new drivers.
>
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Applied to the togreg branch of iio.git.
Glad to see this one go.
Thanks,
Jonathan
> ---
> include/linux/iio/sysfs.h | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/include/linux/iio/sysfs.h b/include/linux/iio/sysfs.h
> index b7a934b..2958c96 100644
> --- a/include/linux/iio/sysfs.h
> +++ b/include/linux/iio/sysfs.h
> @@ -73,11 +73,6 @@ struct iio_const_attr {
> .dev_attr = __ATTR(_name, S_IRUGO, iio_read_const_attr, NULL)}
>
> /* Generic attributes of onetype or another */
> -/**
> - * IIO_DEV_ATTR_RESET: resets the device
> - **/
> -#define IIO_DEV_ATTR_RESET(_store) \
> - IIO_DEVICE_ATTR(reset, S_IWUSR, NULL, _store, 0)
>
> /**
> * IIO_DEV_ATTR_SAMP_FREQ - sets any internal clock frequency
>
next prev parent reply other threads:[~2013-07-16 16:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-16 15:08 [PATCH 1/4] staging:iio:ad2s1210: Don't expose the chip reset to userspace Lars-Peter Clausen
2013-07-16 15:08 ` [PATCH 2/4] staging:iio:adt7316: " Lars-Peter Clausen
2013-07-16 16:57 ` Jonathan Cameron
2013-07-16 15:08 ` [PATCH 3/4] staging:iio:ade7xxx: " Lars-Peter Clausen
2013-07-16 16:57 ` Jonathan Cameron
2013-07-16 15:08 ` [PATCH 4/4] iio: Remove IIO_DEV_ATTR_RESET macro Lars-Peter Clausen
2013-07-16 16:57 ` Jonathan Cameron [this message]
2013-07-16 16:56 ` [PATCH 1/4] staging:iio:ad2s1210: Don't expose the chip reset to userspace Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51E57B95.1090909@kernel.org \
--to=jic23@kernel.org \
--cc=jic23@cam.ac.uk \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).