From: Jonathan Cameron <jic23@kernel.org>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: linux-iio@vger.kernel.org
Subject: Re: [PATCH 15/15] staging:iio:adis16260: Move out of staging
Date: Sat, 27 Jul 2013 13:08:42 +0100 [thread overview]
Message-ID: <51F3B84A.6010707@kernel.org> (raw)
In-Reply-To: <1374072279-7140-15-git-send-email-lars@metafoo.de>
On 07/17/13 15:44, Lars-Peter Clausen wrote:
> The drivers is in more or less good shape, conforms to the IIO ABI and none of
> the default static code checker report any problems, so move it out of staging.
>
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Applied to the togreg branch of iio.git
If you are really bored, the comment just above the id table is clearly untrue
and you could always apply the new devm_ function to make this driver near perfect.
Thanks for all your work on this. I sometimes feel guilty about how many drivers
we still have sitting in staging so good to see another one come out.
Jonathan
> ---
> drivers/iio/gyro/Kconfig | 12 ++++++++++++
> drivers/iio/gyro/Makefile | 1 +
> .../iio/gyro/adis16260_core.c => iio/gyro/adis16260.c} | 0
> drivers/staging/iio/gyro/Kconfig | 12 ------------
> drivers/staging/iio/gyro/Makefile | 3 ---
> 5 files changed, 13 insertions(+), 15 deletions(-)
> rename drivers/{staging/iio/gyro/adis16260_core.c => iio/gyro/adis16260.c} (100%)
>
> diff --git a/drivers/iio/gyro/Kconfig b/drivers/iio/gyro/Kconfig
> index 5913735..41c64a4 100644
> --- a/drivers/iio/gyro/Kconfig
> +++ b/drivers/iio/gyro/Kconfig
> @@ -28,6 +28,18 @@ config ADIS16136
> Say yes here to build support for the Analog Devices ADIS16133, ADIS16135,
> ADIS16136 gyroscope devices.
>
> +config ADIS16260
> + tristate "Analog Devices ADIS16260 Digital Gyroscope Sensor SPI driver"
> + depends on SPI
> + select IIO_ADIS_LIB
> + select IIO_ADIS_LIB_BUFFER if IIO_BUFFER
> + help
> + Say yes here to build support for Analog Devices ADIS16260 ADIS16265
> + ADIS16250 ADIS16255 and ADIS16251 programmable digital gyroscope sensors.
> +
> + This driver can also be built as a module. If so, the module
> + will be called adis16260.
> +
> config ADXRS450
> tristate "Analog Devices ADXRS450/3 Digital Output Gyroscope SPI driver"
> depends on SPI
> diff --git a/drivers/iio/gyro/Makefile b/drivers/iio/gyro/Makefile
> index 36091d5..2f2752a 100644
> --- a/drivers/iio/gyro/Makefile
> +++ b/drivers/iio/gyro/Makefile
> @@ -6,6 +6,7 @@
> obj-$(CONFIG_ADIS16080) += adis16080.o
> obj-$(CONFIG_ADIS16130) += adis16130.o
> obj-$(CONFIG_ADIS16136) += adis16136.o
> +obj-$(CONFIG_ADIS16260) += adis16260.o
> obj-$(CONFIG_ADXRS450) += adxrs450.o
>
> obj-$(CONFIG_HID_SENSOR_GYRO_3D) += hid-sensor-gyro-3d.o
> diff --git a/drivers/staging/iio/gyro/adis16260_core.c b/drivers/iio/gyro/adis16260.c
> similarity index 100%
> rename from drivers/staging/iio/gyro/adis16260_core.c
> rename to drivers/iio/gyro/adis16260.c
> diff --git a/drivers/staging/iio/gyro/Kconfig b/drivers/staging/iio/gyro/Kconfig
> index b433371..88b199b 100644
> --- a/drivers/staging/iio/gyro/Kconfig
> +++ b/drivers/staging/iio/gyro/Kconfig
> @@ -10,16 +10,4 @@ config ADIS16060
> Say yes here to build support for Analog Devices adis16060 wide bandwidth
> yaw rate gyroscope with SPI.
>
> -config ADIS16260
> - tristate "Analog Devices ADIS16260 Digital Gyroscope Sensor SPI driver"
> - depends on SPI
> - select IIO_ADIS_LIB
> - select IIO_ADIS_LIB_BUFFER if IIO_BUFFER
> - help
> - Say yes here to build support for Analog Devices ADIS16260 ADIS16265
> - ADIS16250 ADIS16255 and ADIS16251 programmable digital gyroscope sensors.
> -
> - This driver can also be built as a module. If so, the module
> - will be called adis16260.
> -
> endmenu
> diff --git a/drivers/staging/iio/gyro/Makefile b/drivers/staging/iio/gyro/Makefile
> index 975f95b..cf22d6d 100644
> --- a/drivers/staging/iio/gyro/Makefile
> +++ b/drivers/staging/iio/gyro/Makefile
> @@ -4,6 +4,3 @@
>
> adis16060-y := adis16060_core.o
> obj-$(CONFIG_ADIS16060) += adis16060.o
> -
> -adis16260-y := adis16260_core.o
> -obj-$(CONFIG_ADIS16260) += adis16260.o
>
next prev parent reply other threads:[~2013-07-27 11:08 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-17 14:44 [PATCH 01/15] staging:iio:adis16260: Fix reading calibscale Lars-Peter Clausen
2013-07-17 14:44 ` [PATCH 02/15] staging:iio:adis16260: Drop unused 'negate' property Lars-Peter Clausen
2013-07-27 11:54 ` Jonathan Cameron
2013-07-17 14:44 ` [PATCH 03/15] staging:iio:adis16260: Remove support for orientation mapping Lars-Peter Clausen
2013-07-20 9:28 ` Jonathan Cameron
2013-07-27 11:55 ` Jonathan Cameron
2013-07-17 14:44 ` [PATCH 04/15] staging:iio:adis16260: Don't set default scan mask Lars-Peter Clausen
2013-07-27 11:56 ` Jonathan Cameron
2013-07-17 14:44 ` [PATCH 05/15] staging:iio:adis16260: Remove separate header Lars-Peter Clausen
2013-07-27 11:59 ` Jonathan Cameron
2013-07-17 14:44 ` [PATCH 06/15] staging:iio:adis16260: Add value range check for calibscale/-bias Lars-Peter Clausen
2013-07-27 11:58 ` Jonathan Cameron
2013-07-17 14:44 ` [PATCH 07/15] staging:iio:adis16260: Use sign_extend32() instead of open-coding it Lars-Peter Clausen
2013-07-27 11:59 ` Jonathan Cameron
2013-07-17 14:44 ` [PATCH 08/15] staging:iio:adis16260: Simplify calibscale and caliboffset reading Lars-Peter Clausen
2013-07-27 12:00 ` Jonathan Cameron
2013-07-17 14:44 ` [PATCH 09/15] staging:iio:adis16260: Fix minor style issue Lars-Peter Clausen
2013-07-27 12:01 ` Jonathan Cameron
2013-07-17 14:44 ` [PATCH 10/15] staging:iio:adis16260: Remove 'SPS' suffix from samplerate attribute Lars-Peter Clausen
2013-07-27 12:01 ` Jonathan Cameron
2013-07-17 14:44 ` [PATCH 11/15] staging:iio:adis16260: Add scale for the inclination channel Lars-Peter Clausen
2013-07-27 12:02 ` Jonathan Cameron
2013-07-17 14:44 ` [PATCH 12/15] staging:iio:adis16260: Remove unused includes Lars-Peter Clausen
2013-07-27 12:03 ` Jonathan Cameron
2013-07-17 14:44 ` [PATCH 13/15] staging:iio:adis16260: Add proper range checks to write_frequency() Lars-Peter Clausen
2013-07-27 12:04 ` Jonathan Cameron
2013-07-17 14:44 ` [PATCH 14/15] staging:iio:adis16260: Remove sampling_frequency_available attribute Lars-Peter Clausen
2013-07-27 12:04 ` Jonathan Cameron
2013-07-17 14:44 ` [PATCH 15/15] staging:iio:adis16260: Move out of staging Lars-Peter Clausen
2013-07-27 12:08 ` Jonathan Cameron [this message]
2013-07-27 11:54 ` [PATCH 01/15] staging:iio:adis16260: Fix reading calibscale Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51F3B84A.6010707@kernel.org \
--to=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).