From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Zubair Lutfullah : <zubair.lutfullah@gmail.com>
Cc: "Zubair Lutfullah: zubair.lutfullah"@gmail.com, jic23@cam.ac.uk,
lee.jones@linaro.org, linux-iio@vger.kernel.org,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
gregkh@linuxfoundation.org
Subject: Re: [PATCH 2/2] iio: ti_am335x_adc: Add continuous sampling support
Date: Thu, 29 Aug 2013 09:56:47 +0200 [thread overview]
Message-ID: <521EFEBF.30608@linutronix.de> (raw)
In-Reply-To: <20130828185929.GF3777@gmail.com>
On 08/28/2013 08:59 PM, Zubair Lutfullah : wrote:
>>>>> am335x_tsc_se_clr(adc_dev->mfd_tscadc, step_en);
>>>>> + iio_device_free(indio_dev);
> ...
>> Point me one driver please. Do they use devm_iio_device_alloc() like
>> you do or iio_device_alloc()? In case of the latter you need to
>> manually free the memory.
> Aah. So the devm_* stuff makes the difference.
> Thanks for pointing it out. Will remove it.
Yes, devm_* stuff. There is also matching kmalloc() version of it for
the very same purpose and a few others…
In future please post a bugfix (adding iio_device_free() to plug a
memory leak) as a separate patch. It has nothing todo with "continuous
sampling support" and it case it is valid it could be applied
independantly and ported back to earlier kernel if necessary. The way
you did here you just "silently" plugged a memory leak.
>
> ZubairLK
>
Sebastian
next prev parent reply other threads:[~2013-08-29 7:56 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-25 22:45 [PATCH V6 0/2] iio: input: ti_am335x_adc: Add continuous sampling support Zubair Lutfullah
2013-08-25 22:45 ` [PATCH 1/2] input: ti_am335x_tsc: Enable shared IRQ for TSC Zubair Lutfullah
2013-08-28 10:42 ` Sebastian Andrzej Siewior
2013-08-28 18:49 ` Zubair Lutfullah :
2013-08-25 22:45 ` [PATCH 2/2] iio: ti_am335x_adc: Add continuous sampling support Zubair Lutfullah
2013-08-27 8:42 ` Lee Jones
2013-08-28 10:31 ` [PATCH] iio: am335x-iio-adc: select triggered buffer Sebastian Andrzej Siewior
2013-08-28 18:32 ` Zubair Lutfullah :
2013-08-28 13:01 ` [PATCH 2/2] iio: ti_am335x_adc: Add continuous sampling support Sebastian Andrzej Siewior
2013-08-28 18:43 ` Zubair Lutfullah :
2013-08-29 7:49 ` Sebastian Andrzej Siewior
2013-08-28 14:18 ` Sebastian Andrzej Siewior
2013-08-28 18:22 ` Zubair Lutfullah :
2013-08-28 18:38 ` Sebastian Andrzej Siewior
2013-08-28 18:55 ` Zubair Lutfullah :
2013-08-28 16:43 ` Sebastian Andrzej Siewior
2013-08-28 18:19 ` Zubair Lutfullah :
2013-08-28 18:35 ` Sebastian Andrzej Siewior
2013-08-28 18:59 ` Zubair Lutfullah :
2013-08-29 7:56 ` Sebastian Andrzej Siewior [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-09-01 11:07 [PATCH V7 0/2] iio: input: ti_am335x_tscadc: Add continuous sampling support to adc Zubair Lutfullah
2013-09-01 11:07 ` [PATCH 2/2] iio: ti_am335x_adc: Add continuous sampling support Zubair Lutfullah
2013-09-01 11:17 [PATCH V8 0/2] iio: input: ti_am335x_tscadc: Add continuous sampling support to adc Zubair Lutfullah
2013-09-01 11:17 ` [PATCH 2/2] iio: ti_am335x_adc: Add continuous sampling support Zubair Lutfullah
2013-09-08 13:42 ` Jonathan Cameron
2013-09-11 16:02 ` Zubair Lutfullah :
2013-09-17 4:44 [PATCH V9 0/2] iio: input: " Zubair Lutfullah
2013-09-17 4:44 ` [PATCH 2/2] iio: " Zubair Lutfullah
2013-09-18 4:27 ` Dmitry Torokhov
2013-09-18 6:54 ` Zubair Lutfullah :
2013-09-18 9:39 ` Jonathan Cameron
2013-09-18 11:25 ` Zubair Lutfullah :
2013-09-18 14:15 ` Dmitry Torokhov
2013-09-18 16:12 ` Jonathan Cameron
2013-09-18 16:24 ` Dmitry Torokhov
2013-09-18 17:05 ` Jonathan Cameron
2013-09-19 5:16 ` Zubair Lutfullah :
2013-09-19 5:33 ` Jonathan Cameron
2013-09-18 11:23 [PATCH V10 0/2] iio: input: " Zubair Lutfullah
2013-09-18 11:23 ` [PATCH 2/2] iio: " Zubair Lutfullah
2013-09-18 13:58 ` Jonathan Cameron
2013-09-19 5:24 ` Zubair Lutfullah :
2013-09-19 5:41 ` Jonathan Cameron
2013-09-19 5:55 ` Zubair Lutfullah :
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=521EFEBF.30608@linutronix.de \
--to=bigeasy@linutronix.de \
--cc="Zubair Lutfullah: zubair.lutfullah"@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@cam.ac.uk \
--cc=lee.jones@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zubair.lutfullah@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).