From: Jonathan Cameron <jic23@kernel.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: linux-iio@vger.kernel.org, fengguang.wu@intel.com
Subject: Re: [PATCH] staging:iio:dummy fix kfifo_buf kconfig dependency issue if kfifo modular and buffer enabled for built in dummy driver.
Date: Sun, 08 Sep 2013 12:26:21 +0100 [thread overview]
Message-ID: <522C5EDD.5050902@kernel.org> (raw)
In-Reply-To: <5223EB12.1050904@infradead.org>
On 09/02/13 02:34, Randy Dunlap wrote:
> On 09/01/13 10:55, Jonathan Cameron wrote:
>> This only occurs in the unlikely event that the example driver is built
>> in whilst the buffer implementation is not.
>>
>> Solved by switching from a depends on to a select for this particular case.
>>
>> Reported-by: Fengguang Wu <fengguang.wu@intel.com>
>> Reported-by: Randy Dunlap <rdunlap@infradead.org>
>> Signed-off-by: Jonathan Cameron <jic23@kernel.org>
>
> Acked-by: Randy Dunlap <rdunlap@infradead.org>
applied to the fixes-togreg branch of iio.git. I'll send
this on to Greg once rc1 is out.
>
> Thanks.
>
>> ---
>> drivers/staging/iio/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/iio/Kconfig b/drivers/staging/iio/Kconfig
>> index db4d6dc..b36feb0 100644
>> --- a/drivers/staging/iio/Kconfig
>> +++ b/drivers/staging/iio/Kconfig
>> @@ -37,7 +37,7 @@ config IIO_SIMPLE_DUMMY_EVENTS
>>
>> config IIO_SIMPLE_DUMMY_BUFFER
>> boolean "Buffered capture support"
>> - depends on IIO_KFIFO_BUF
>> + select IIO_KFIFO_BUF
>> help
>> Add buffered data capture to the simple dummy driver.
>>
>>
>
>
prev parent reply other threads:[~2013-09-08 10:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20130723235123.GA25723@localhost>
2013-09-01 17:55 ` [PATCH] staging:iio:dummy fix kfifo_buf kconfig dependency issue if kfifo modular and buffer enabled for built in dummy driver Jonathan Cameron
2013-09-02 1:34 ` Randy Dunlap
2013-09-08 11:26 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=522C5EDD.5050902@kernel.org \
--to=jic23@kernel.org \
--cc=fengguang.wu@intel.com \
--cc=linux-iio@vger.kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).