From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from saturn.retrosnub.co.uk ([178.18.118.26]:36383 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752502Ab3IHK0S (ORCPT ); Sun, 8 Sep 2013 06:26:18 -0400 Message-ID: <522C5EDD.5050902@kernel.org> Date: Sun, 08 Sep 2013 12:26:21 +0100 From: Jonathan Cameron MIME-Version: 1.0 To: Randy Dunlap CC: linux-iio@vger.kernel.org, fengguang.wu@intel.com Subject: Re: [PATCH] staging:iio:dummy fix kfifo_buf kconfig dependency issue if kfifo modular and buffer enabled for built in dummy driver. References: <20130723235123.GA25723@localhost> <1378058136-18453-1-git-send-email-jic23@kernel.org> <5223EB12.1050904@infradead.org> In-Reply-To: <5223EB12.1050904@infradead.org> Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org On 09/02/13 02:34, Randy Dunlap wrote: > On 09/01/13 10:55, Jonathan Cameron wrote: >> This only occurs in the unlikely event that the example driver is built >> in whilst the buffer implementation is not. >> >> Solved by switching from a depends on to a select for this particular case. >> >> Reported-by: Fengguang Wu >> Reported-by: Randy Dunlap >> Signed-off-by: Jonathan Cameron > > Acked-by: Randy Dunlap applied to the fixes-togreg branch of iio.git. I'll send this on to Greg once rc1 is out. > > Thanks. > >> --- >> drivers/staging/iio/Kconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/staging/iio/Kconfig b/drivers/staging/iio/Kconfig >> index db4d6dc..b36feb0 100644 >> --- a/drivers/staging/iio/Kconfig >> +++ b/drivers/staging/iio/Kconfig >> @@ -37,7 +37,7 @@ config IIO_SIMPLE_DUMMY_EVENTS >> >> config IIO_SIMPLE_DUMMY_BUFFER >> boolean "Buffered capture support" >> - depends on IIO_KFIFO_BUF >> + select IIO_KFIFO_BUF >> help >> Add buffered data capture to the simple dummy driver. >> >> > >