From: Jonathan Cameron <jic23@kernel.org>
To: Sachin Kamat <sachin.kamat@linaro.org>
Cc: linux-iio@vger.kernel.org, Lars-Peter Clausen <lars@metafoo.de>,
"J. August Brenner" <jbrenner@taosinc.com>
Subject: Re: [PATCH 02/12] staging: iio: tsl2583: Use devm_iio_device_alloc
Date: Sun, 08 Sep 2013 15:32:44 +0100 [thread overview]
Message-ID: <522C8A8C.1020206@kernel.org> (raw)
In-Reply-To: <CAK9yfHwd3AcppOhF7OT81R3pOUNwpYZt1U1DW+=tggzx=oU7Xw@mail.gmail.com>
On 09/08/13 14:14, Sachin Kamat wrote:
> Hi Jonathan,
>
> On 8 September 2013 02:29, Jonathan Cameron <jic23@kernel.org> wrote:
>> On 09/05/13 10:29, Sachin Kamat wrote:
>>> devm_iio_device_alloc makes the code simple. While at it also
>>> fixed an uninitialized return with -EINVAL.
>>>
>>> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
>>> Cc: J. August Brenner <jbrenner@taosinc.com>
>> Applied to the togreg branch of iio.git. Jon mentioned he was very
>> busy so I won't wait for his feedback on this. Ideally this would have
>> been two patches, the fix and the devm stuff on top of that so that
>> we could push the fix into stable if anyone cares. Here it is obscure
>> enough I doubt anyone ever will so never mind.
>
> I can probably still do that. Create a patch just to fix this on top
> of your fixes branch which can go into
> 3.12-rc and below. But you may have to resolve a conflict (I believe
> this one might give) when you merge
> it with your togreg branch. Let me know your opinion in any case.
Don't worry about it. It is pretty obscure and we don't know if anyone
has ever actually hit it!
>
>>
>> Applied to the togreg branch of iio.git
>
> Thanks for applying this and all others :)
>
next prev parent reply other threads:[~2013-09-08 13:32 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-05 9:29 [PATCH 01/12] staging: iio: ad5933: Use devm_* APIs Sachin Kamat
2013-09-05 9:29 ` [PATCH 02/12] staging: iio: tsl2583: Use devm_iio_device_alloc Sachin Kamat
2013-09-07 20:59 ` Jonathan Cameron
2013-09-08 13:14 ` Sachin Kamat
2013-09-08 14:32 ` Jonathan Cameron [this message]
2013-09-05 9:29 ` [PATCH 03/12] staging: iio: ad5930: " Sachin Kamat
2013-09-07 21:00 ` Jonathan Cameron
2013-09-05 9:29 ` [PATCH 04/12] staging: iio: ad9832: Use devm_* APIs Sachin Kamat
2013-09-07 21:01 ` Jonathan Cameron
2013-09-05 9:29 ` [PATCH 05/12] staging: iio: ad9834: " Sachin Kamat
2013-09-07 21:02 ` Jonathan Cameron
2013-09-05 9:29 ` [PATCH 06/12] staging: iio: ad9850: Use devm_iio_device_alloc Sachin Kamat
2013-09-07 21:02 ` Jonathan Cameron
2013-09-05 9:29 ` [PATCH 07/12] staging: iio: ad9852: " Sachin Kamat
2013-09-07 21:03 ` Jonathan Cameron
2013-09-05 9:29 ` [PATCH 08/12] staging: iio: ad9910: " Sachin Kamat
2013-09-07 21:03 ` Jonathan Cameron
2013-09-05 9:29 ` [PATCH 09/12] staging: iio: ad9951: " Sachin Kamat
2013-09-07 21:04 ` Jonathan Cameron
2013-09-05 9:29 ` [PATCH 10/12] staging: iio: tsl2x7x_core: Use devm_* APIs Sachin Kamat
2013-09-07 21:05 ` Jonathan Cameron
2013-09-05 9:29 ` [PATCH 11/12] staging: iio: tsl2x7x_core: Fix sparse warning Sachin Kamat
2013-09-07 21:06 ` Jonathan Cameron
2013-09-05 9:29 ` [PATCH 12/12] staging: iio: hmc5843: Fix a trivial typo Sachin Kamat
2013-09-07 21:07 ` Jonathan Cameron
2013-09-07 20:53 ` [PATCH 01/12] staging: iio: ad5933: Use devm_* APIs Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=522C8A8C.1020206@kernel.org \
--to=jic23@kernel.org \
--cc=jbrenner@taosinc.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=sachin.kamat@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).