* [PATCH 2/5] iio: gyro: adis16260: Remove redundant break
2013-09-11 10:20 [PATCH 1/5] iio: gyro: adis16130: Remove redundant break Sachin Kamat
@ 2013-09-11 10:20 ` Sachin Kamat
2013-09-14 10:37 ` Jonathan Cameron
2013-09-11 10:20 ` [PATCH 3/5] iio: gyro: adxrs450: " Sachin Kamat
` (3 subsequent siblings)
4 siblings, 1 reply; 10+ messages in thread
From: Sachin Kamat @ 2013-09-11 10:20 UTC (permalink / raw)
To: linux-iio; +Cc: jic23, sachin.kamat
'break' after return is redundant. Remove it.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
drivers/iio/gyro/adis16260.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/iio/gyro/adis16260.c b/drivers/iio/gyro/adis16260.c
index 0654116..22b6fb8 100644
--- a/drivers/iio/gyro/adis16260.c
+++ b/drivers/iio/gyro/adis16260.c
@@ -239,7 +239,6 @@ static int adis16260_read_raw(struct iio_dev *indio_dev,
default:
return -EINVAL;
}
- break;
case IIO_CHAN_INFO_OFFSET:
*val = 250000 / 1453; /* 25 C = 0x00 */
return IIO_VAL_INT;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH 2/5] iio: gyro: adis16260: Remove redundant break
2013-09-11 10:20 ` [PATCH 2/5] iio: gyro: adis16260: " Sachin Kamat
@ 2013-09-14 10:37 ` Jonathan Cameron
0 siblings, 0 replies; 10+ messages in thread
From: Jonathan Cameron @ 2013-09-14 10:37 UTC (permalink / raw)
To: Sachin Kamat; +Cc: linux-iio
On 09/11/13 11:20, Sachin Kamat wrote:
> 'break' after return is redundant. Remove it.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Applied to the togreg branch of iio.git
> ---
> drivers/iio/gyro/adis16260.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/iio/gyro/adis16260.c b/drivers/iio/gyro/adis16260.c
> index 0654116..22b6fb8 100644
> --- a/drivers/iio/gyro/adis16260.c
> +++ b/drivers/iio/gyro/adis16260.c
> @@ -239,7 +239,6 @@ static int adis16260_read_raw(struct iio_dev *indio_dev,
> default:
> return -EINVAL;
> }
> - break;
> case IIO_CHAN_INFO_OFFSET:
> *val = 250000 / 1453; /* 25 C = 0x00 */
> return IIO_VAL_INT;
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 3/5] iio: gyro: adxrs450: Remove redundant break
2013-09-11 10:20 [PATCH 1/5] iio: gyro: adis16130: Remove redundant break Sachin Kamat
2013-09-11 10:20 ` [PATCH 2/5] iio: gyro: adis16260: " Sachin Kamat
@ 2013-09-11 10:20 ` Sachin Kamat
2013-09-14 10:37 ` Jonathan Cameron
2013-09-11 10:20 ` [PATCH 4/5] iio: dac: ad5686: " Sachin Kamat
` (2 subsequent siblings)
4 siblings, 1 reply; 10+ messages in thread
From: Sachin Kamat @ 2013-09-11 10:20 UTC (permalink / raw)
To: linux-iio; +Cc: jic23, sachin.kamat
'break' after return is redundant. Remove it.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
drivers/iio/gyro/adxrs450.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/iio/gyro/adxrs450.c b/drivers/iio/gyro/adxrs450.c
index 6dab299..c1f40ef 100644
--- a/drivers/iio/gyro/adxrs450.c
+++ b/drivers/iio/gyro/adxrs450.c
@@ -354,7 +354,6 @@ static int adxrs450_read_raw(struct iio_dev *indio_dev,
default:
return -EINVAL;
}
- break;
case IIO_CHAN_INFO_QUADRATURE_CORRECTION_RAW:
ret = adxrs450_spi_read_reg_16(indio_dev, ADXRS450_QUAD1, &t);
if (ret)
--
1.7.9.5
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH 3/5] iio: gyro: adxrs450: Remove redundant break
2013-09-11 10:20 ` [PATCH 3/5] iio: gyro: adxrs450: " Sachin Kamat
@ 2013-09-14 10:37 ` Jonathan Cameron
0 siblings, 0 replies; 10+ messages in thread
From: Jonathan Cameron @ 2013-09-14 10:37 UTC (permalink / raw)
To: Sachin Kamat; +Cc: linux-iio
On 09/11/13 11:20, Sachin Kamat wrote:
> 'break' after return is redundant. Remove it.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Applied to the togreg branch of iio.git
> ---
> drivers/iio/gyro/adxrs450.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/iio/gyro/adxrs450.c b/drivers/iio/gyro/adxrs450.c
> index 6dab299..c1f40ef 100644
> --- a/drivers/iio/gyro/adxrs450.c
> +++ b/drivers/iio/gyro/adxrs450.c
> @@ -354,7 +354,6 @@ static int adxrs450_read_raw(struct iio_dev *indio_dev,
> default:
> return -EINVAL;
> }
> - break;
> case IIO_CHAN_INFO_QUADRATURE_CORRECTION_RAW:
> ret = adxrs450_spi_read_reg_16(indio_dev, ADXRS450_QUAD1, &t);
> if (ret)
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 4/5] iio: dac: ad5686: Remove redundant break
2013-09-11 10:20 [PATCH 1/5] iio: gyro: adis16130: Remove redundant break Sachin Kamat
2013-09-11 10:20 ` [PATCH 2/5] iio: gyro: adis16260: " Sachin Kamat
2013-09-11 10:20 ` [PATCH 3/5] iio: gyro: adxrs450: " Sachin Kamat
@ 2013-09-11 10:20 ` Sachin Kamat
2013-09-14 10:37 ` Jonathan Cameron
2013-09-11 10:20 ` [PATCH 5/5] staging: iio: tsl2x7x_core: " Sachin Kamat
2013-09-14 10:37 ` [PATCH 1/5] iio: gyro: adis16130: " Jonathan Cameron
4 siblings, 1 reply; 10+ messages in thread
From: Sachin Kamat @ 2013-09-11 10:20 UTC (permalink / raw)
To: linux-iio; +Cc: jic23, sachin.kamat
'break' after return is redundant. Remove it.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
drivers/iio/dac/ad5686.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/iio/dac/ad5686.c b/drivers/iio/dac/ad5686.c
index 57825ea..3e1080f 100644
--- a/drivers/iio/dac/ad5686.c
+++ b/drivers/iio/dac/ad5686.c
@@ -213,7 +213,6 @@ static int ad5686_read_raw(struct iio_dev *indio_dev,
return ret;
*val = ret;
return IIO_VAL_INT;
- break;
case IIO_CHAN_INFO_SCALE:
scale_uv = (st->vref_mv * 100000)
>> (chan->scan_type.realbits);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH 4/5] iio: dac: ad5686: Remove redundant break
2013-09-11 10:20 ` [PATCH 4/5] iio: dac: ad5686: " Sachin Kamat
@ 2013-09-14 10:37 ` Jonathan Cameron
0 siblings, 0 replies; 10+ messages in thread
From: Jonathan Cameron @ 2013-09-14 10:37 UTC (permalink / raw)
To: Sachin Kamat; +Cc: linux-iio
On 09/11/13 11:20, Sachin Kamat wrote:
> 'break' after return is redundant. Remove it.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Applied to the togreg branch of iio.git
> ---
> drivers/iio/dac/ad5686.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/iio/dac/ad5686.c b/drivers/iio/dac/ad5686.c
> index 57825ea..3e1080f 100644
> --- a/drivers/iio/dac/ad5686.c
> +++ b/drivers/iio/dac/ad5686.c
> @@ -213,7 +213,6 @@ static int ad5686_read_raw(struct iio_dev *indio_dev,
> return ret;
> *val = ret;
> return IIO_VAL_INT;
> - break;
> case IIO_CHAN_INFO_SCALE:
> scale_uv = (st->vref_mv * 100000)
> >> (chan->scan_type.realbits);
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 5/5] staging: iio: tsl2x7x_core: Remove redundant break
2013-09-11 10:20 [PATCH 1/5] iio: gyro: adis16130: Remove redundant break Sachin Kamat
` (2 preceding siblings ...)
2013-09-11 10:20 ` [PATCH 4/5] iio: dac: ad5686: " Sachin Kamat
@ 2013-09-11 10:20 ` Sachin Kamat
2013-09-14 10:37 ` Jonathan Cameron
2013-09-14 10:37 ` [PATCH 1/5] iio: gyro: adis16130: " Jonathan Cameron
4 siblings, 1 reply; 10+ messages in thread
From: Sachin Kamat @ 2013-09-11 10:20 UTC (permalink / raw)
To: linux-iio; +Cc: jic23, sachin.kamat
'break' after return is redundant. Remove it.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
drivers/staging/iio/light/tsl2x7x_core.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/drivers/staging/iio/light/tsl2x7x_core.c b/drivers/staging/iio/light/tsl2x7x_core.c
index 3439d37..9c43dcf 100644
--- a/drivers/staging/iio/light/tsl2x7x_core.c
+++ b/drivers/staging/iio/light/tsl2x7x_core.c
@@ -951,7 +951,6 @@ static ssize_t tsl2x7x_gain_available_show(struct device *dev,
case tsl2771:
case tmd2771:
return snprintf(buf, PAGE_SIZE, "%s\n", "1 8 16 128");
- break;
}
return snprintf(buf, PAGE_SIZE, "%s\n", "1 8 16 120");
@@ -1346,7 +1345,6 @@ static int tsl2x7x_read_raw(struct iio_dev *indio_dev,
break;
default:
return -EINVAL;
- break;
}
break;
case IIO_CHAN_INFO_RAW:
@@ -1366,7 +1364,6 @@ static int tsl2x7x_read_raw(struct iio_dev *indio_dev,
break;
default:
return -EINVAL;
- break;
}
break;
case IIO_CHAN_INFO_CALIBSCALE:
@@ -1419,7 +1416,6 @@ static int tsl2x7x_write_raw(struct iio_dev *indio_dev,
case tsl2772:
case tmd2772:
return -EINVAL;
- break;
}
chip->tsl2x7x_settings.als_gain = 3;
break;
@@ -1431,7 +1427,6 @@ static int tsl2x7x_write_raw(struct iio_dev *indio_dev,
case tsl2771:
case tmd2771:
return -EINVAL;
- break;
}
chip->tsl2x7x_settings.als_gain = 3;
break;
@@ -1508,18 +1503,15 @@ static int tsl2x7x_device_id(unsigned char *id, int target)
case tsl2671:
case tsl2771:
return ((*id & 0xf0) == TRITON_ID);
- break;
case tmd2671:
case tmd2771:
return ((*id & 0xf0) == HALIBUT_ID);
- break;
case tsl2572:
case tsl2672:
case tmd2672:
case tsl2772:
case tmd2772:
return ((*id & 0xf0) == SWORDFISH_ID);
- break;
}
return -EINVAL;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH 5/5] staging: iio: tsl2x7x_core: Remove redundant break
2013-09-11 10:20 ` [PATCH 5/5] staging: iio: tsl2x7x_core: " Sachin Kamat
@ 2013-09-14 10:37 ` Jonathan Cameron
0 siblings, 0 replies; 10+ messages in thread
From: Jonathan Cameron @ 2013-09-14 10:37 UTC (permalink / raw)
To: Sachin Kamat; +Cc: linux-iio
On 09/11/13 11:20, Sachin Kamat wrote:
> 'break' after return is redundant. Remove it.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Applied to the togreg branch of iio.git
> ---
> drivers/staging/iio/light/tsl2x7x_core.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/drivers/staging/iio/light/tsl2x7x_core.c b/drivers/staging/iio/light/tsl2x7x_core.c
> index 3439d37..9c43dcf 100644
> --- a/drivers/staging/iio/light/tsl2x7x_core.c
> +++ b/drivers/staging/iio/light/tsl2x7x_core.c
> @@ -951,7 +951,6 @@ static ssize_t tsl2x7x_gain_available_show(struct device *dev,
> case tsl2771:
> case tmd2771:
> return snprintf(buf, PAGE_SIZE, "%s\n", "1 8 16 128");
> - break;
> }
>
> return snprintf(buf, PAGE_SIZE, "%s\n", "1 8 16 120");
> @@ -1346,7 +1345,6 @@ static int tsl2x7x_read_raw(struct iio_dev *indio_dev,
> break;
> default:
> return -EINVAL;
> - break;
> }
> break;
> case IIO_CHAN_INFO_RAW:
> @@ -1366,7 +1364,6 @@ static int tsl2x7x_read_raw(struct iio_dev *indio_dev,
> break;
> default:
> return -EINVAL;
> - break;
> }
> break;
> case IIO_CHAN_INFO_CALIBSCALE:
> @@ -1419,7 +1416,6 @@ static int tsl2x7x_write_raw(struct iio_dev *indio_dev,
> case tsl2772:
> case tmd2772:
> return -EINVAL;
> - break;
> }
> chip->tsl2x7x_settings.als_gain = 3;
> break;
> @@ -1431,7 +1427,6 @@ static int tsl2x7x_write_raw(struct iio_dev *indio_dev,
> case tsl2771:
> case tmd2771:
> return -EINVAL;
> - break;
> }
> chip->tsl2x7x_settings.als_gain = 3;
> break;
> @@ -1508,18 +1503,15 @@ static int tsl2x7x_device_id(unsigned char *id, int target)
> case tsl2671:
> case tsl2771:
> return ((*id & 0xf0) == TRITON_ID);
> - break;
> case tmd2671:
> case tmd2771:
> return ((*id & 0xf0) == HALIBUT_ID);
> - break;
> case tsl2572:
> case tsl2672:
> case tmd2672:
> case tsl2772:
> case tmd2772:
> return ((*id & 0xf0) == SWORDFISH_ID);
> - break;
> }
>
> return -EINVAL;
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/5] iio: gyro: adis16130: Remove redundant break
2013-09-11 10:20 [PATCH 1/5] iio: gyro: adis16130: Remove redundant break Sachin Kamat
` (3 preceding siblings ...)
2013-09-11 10:20 ` [PATCH 5/5] staging: iio: tsl2x7x_core: " Sachin Kamat
@ 2013-09-14 10:37 ` Jonathan Cameron
4 siblings, 0 replies; 10+ messages in thread
From: Jonathan Cameron @ 2013-09-14 10:37 UTC (permalink / raw)
To: Sachin Kamat; +Cc: linux-iio
On 09/11/13 11:20, Sachin Kamat wrote:
> 'break' after return is redundant. Remove it.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Applied to the togreg branch of iio.git
> ---
> drivers/iio/gyro/adis16130.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/iio/gyro/adis16130.c b/drivers/iio/gyro/adis16130.c
> index ac66fc1..9155cf6 100644
> --- a/drivers/iio/gyro/adis16130.c
> +++ b/drivers/iio/gyro/adis16130.c
> @@ -103,7 +103,6 @@ static int adis16130_read_raw(struct iio_dev *indio_dev,
> default:
> return -EINVAL;
> }
> - break;
> case IIO_CHAN_INFO_OFFSET:
> switch (chan->type) {
> case IIO_ANGL_VEL:
> @@ -115,7 +114,6 @@ static int adis16130_read_raw(struct iio_dev *indio_dev,
> default:
> return -EINVAL;
> }
> - break;
> }
>
> return -EINVAL;
>
^ permalink raw reply [flat|nested] 10+ messages in thread