From: Jonathan Cameron <jic23@kernel.org>
To: Peter Meerwald <pmeerw@pmeerw.net>
Cc: linux-iio@vger.kernel.org, Jon Brenner <jon.brenner@ams.com>
Subject: Re: [PATCH 3/4] iio: Add tsl4531 ambient light sensor driver
Date: Sat, 14 Sep 2013 12:21:40 +0100 [thread overview]
Message-ID: <523446C4.7030808@kernel.org> (raw)
In-Reply-To: <1378653659-15665-4-git-send-email-pmeerw@pmeerw.net>
On 09/08/13 16:20, Peter Meerwald wrote:
> driver for the TSL4531 family of 16-bit I2C ambient light
> sensors; information is here:
> http://www.ams.com/eng/Products/Light-Sensors/Ambient-Light-Sensor-ALS/TSL45315
>
> the chip offers simple lux output
>
> v3 (thanks Lars-Peter Clausen):
> * add mutex to when updating integration time
> * fix chip ID checking
> * code cleanups
> v2:
> * rename to tsl4351
> * use INT_TIME
>
> Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
> Cc: Jon Brenner <jon.brenner@ams.com>
Clean, concise and easy to review. This is the sort of driver
I like! To be fair you were assisted here by the hardware designers
making a device that fits remarkably well with our interfaces ;)
Applied to the togreg branch of iio.git.
One little question, what is 'single cycle measurement' referring to in the TODO note?
Thanks,
Jonathan
next prev parent reply other threads:[~2013-09-14 10:21 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-08 15:20 [PATCH 0/4] add INT_TIME and drivers using it Peter Meerwald
2013-09-08 15:20 ` [PATCH 1/4] iio: Add INT_TIME (integration time) channel info attribute Peter Meerwald
2013-09-14 11:11 ` Jonathan Cameron
2013-09-08 15:20 ` [PATCH 2/4] iio: adjd_s311: Use INT_TIME channel info Peter Meerwald
2013-09-14 11:15 ` Jonathan Cameron
2013-09-08 15:20 ` [PATCH 3/4] iio: Add tsl4531 ambient light sensor driver Peter Meerwald
2013-09-14 11:21 ` Jonathan Cameron [this message]
2013-09-14 19:13 ` Peter Meerwald
2013-09-14 20:18 ` Jonathan Cameron
2013-09-08 15:20 ` [PATCH 4/4] iio: Add tcs3472 color " Peter Meerwald
2013-09-14 11:42 ` Jonathan Cameron
2013-09-14 19:38 ` [PATCH v2] " Peter Meerwald
2013-09-14 20:46 ` Jonathan Cameron
2013-09-15 15:51 ` Peter Meerwald
2013-09-15 15:52 ` [PATCH] iio: Fix tcs3472 buffer size Peter Meerwald
2013-09-15 16:54 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=523446C4.7030808@kernel.org \
--to=jic23@kernel.org \
--cc=jon.brenner@ams.com \
--cc=linux-iio@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).