linux-iio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: linux-iio@vger.kernel.org
Subject: Re: [PATCH V3 0/5] IIO: Refactor info_mask* and ext_info handling and introduce info_mask_shared_[by_all/by_type]
Date: Sun, 15 Sep 2013 17:49:31 +0100	[thread overview]
Message-ID: <5235E51B.5050800@kernel.org> (raw)
In-Reply-To: <5235D500.8030403@metafoo.de>

On 09/15/13 16:40, Lars-Peter Clausen wrote:
> On 09/08/2013 03:57 PM, Jonathan Cameron wrote:
>> Changes since V2.
>> 1) Fixed formatting in the iio_shared_by enum definition as pointed out
>>    by Lars.
>>
>> Changes since V1.
>> 1) Deal with ext_info as well as the info_mask.
>>    In the previous set things sort of worked by coincidence of the ordering
>>    in the enum.  This version handles this cleanly.
>> 2) Dropped the bonus const in tmp006.
>>
>> Original message :
>>
>> This series first performs a bit of refactoring of the core handling
>> of info_mask_separate and info_mask_shared_by_type.
>>
>> Next we introduce info_mask_shared_by_dir and info_mask_shared_by_all
>> to allow for attributes of the form
>>
>> in_sampling_frequency or sampling_frequency as appropriate.
>>
>> Most existing drivers will make no use of the shared_by_dir
>> case, but it is there to handle devices with both and input and
>> output channels.
>>
>> There are two main reasons for adding these two cases.
>> 1) Should result in shorter code, particularly for complex drivers.
>> 2) Allows for in kernel consumers accessing this functionality.
>>
>> The intent is to follow this series with one providing a standard
>> way of providing 'available' attributes.  The combination of the
>> two should mean that very few things are still handled via direct
>> registration of attributes.
>>
>> Thanks,
>>
>> Jonathan
> 
> Looks good to me, all patches
> 
> Reviewed-by: Lars-Peter Clausen <lars@metafoo.de>

Thanks Lars.

All applied to the togreg branch of iio.git.

> 
>>
>> Jonathan Cameron (5):
>>   iio: drop info_mask from struct iio_dev
>>   iio: refactor info mask and ext_info attribute creation.
>>   iio: add info_mask_[shared_by_dir/shared_by_all]
>>   staging:iio: dummy driver additions to show shared_by_dir infomask
>>     usage
>>   iio:temperature:tmp006 put sampling_frequency in
>>     info_mask_shared_by_all
>>
>>  drivers/iio/dac/ad5064.c               |   3 +-
>>  drivers/iio/dac/ad5380.c               |   4 +-
>>  drivers/iio/dac/ad5446.c               |   3 +-
>>  drivers/iio/dac/ad5504.c               |   4 +-
>>  drivers/iio/dac/ad5624r_spi.c          |   4 +-
>>  drivers/iio/dac/ad5686.c               |   3 +-
>>  drivers/iio/dac/ad5755.c               |   1 +
>>  drivers/iio/dac/ad5791.c               |   5 +-
>>  drivers/iio/dac/ad7303.c               |   1 +
>>  drivers/iio/dac/mcp4725.c              |   3 +-
>>  drivers/iio/frequency/adf4350.c        |   1 +
>>  drivers/iio/iio_core.h                 |   2 +-
>>  drivers/iio/industrialio-buffer.c      |   2 +-
>>  drivers/iio/industrialio-core.c        | 179 ++++++++++++++++++++-------------
>>  drivers/iio/temperature/tmp006.c       |  57 +++++------
>>  drivers/staging/iio/iio_simple_dummy.c |  16 +++
>>  include/linux/iio/iio.h                |  26 +++--
>>  17 files changed, 197 insertions(+), 117 deletions(-)
>>
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

      reply	other threads:[~2013-09-15 15:49 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-08 13:57 [PATCH V3 0/5] IIO: Refactor info_mask* and ext_info handling and introduce info_mask_shared_[by_all/by_type] Jonathan Cameron
2013-09-08 13:57 ` [PATCH 1/5] iio: drop info_mask from struct iio_dev Jonathan Cameron
2013-09-08 13:57 ` [PATCH 2/5] iio: refactor info mask and ext_info attribute creation Jonathan Cameron
2013-09-08 13:57 ` [PATCH 3/5] iio: add info_mask_[shared_by_dir/shared_by_all] Jonathan Cameron
2013-09-08 13:57 ` [PATCH 4/5] staging:iio: dummy driver additions to show shared_by_dir infomask usage Jonathan Cameron
2013-09-08 13:57 ` [PATCH 5/5] iio:temperature:tmp006 put sampling_frequency in info_mask_shared_by_all Jonathan Cameron
2013-09-15 15:40 ` [PATCH V3 0/5] IIO: Refactor info_mask* and ext_info handling and introduce info_mask_shared_[by_all/by_type] Lars-Peter Clausen
2013-09-15 16:49   ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5235E51B.5050800@kernel.org \
    --to=jic23@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).