From: Jonathan Cameron <jic23@kernel.org>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: linux-iio@vger.kernel.org
Subject: Re: [PATCH] iio:buffer_cb: Constify iio_cb_access
Date: Sun, 15 Sep 2013 18:58:43 +0100 [thread overview]
Message-ID: <5235F553.8090802@kernel.org> (raw)
In-Reply-To: <1379261395-16304-1-git-send-email-lars@metafoo.de>
On 09/15/13 17:09, Lars-Peter Clausen wrote:
> The iio_cb_access struct is never modified so we can mark it as const.
>
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Good point.
Applied to the togreg branch of iio.git
Thanks,
Jonathan
> ---
> drivers/iio/buffer_cb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/buffer_cb.c b/drivers/iio/buffer_cb.c
> index 9d19ba7..f406889 100644
> --- a/drivers/iio/buffer_cb.c
> +++ b/drivers/iio/buffer_cb.c
> @@ -21,7 +21,7 @@ static int iio_buffer_cb_store_to(struct iio_buffer *buffer, u8 *data)
> return cb_buff->cb(data, cb_buff->private);
> }
>
> -static struct iio_buffer_access_funcs iio_cb_access = {
> +static const struct iio_buffer_access_funcs iio_cb_access = {
> .store_to = &iio_buffer_cb_store_to,
> };
>
>
prev parent reply other threads:[~2013-09-15 16:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-15 16:09 [PATCH] iio:buffer_cb: Constify iio_cb_access Lars-Peter Clausen
2013-09-15 17:58 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5235F553.8090802@kernel.org \
--to=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).