* [PATCH 3/10] iio: at91_adc: Cocci spatch "noderef" [not found] <1379604755850-858421494-0-diffsplit-thomas@m3y3r.de> @ 2013-09-19 21:42 ` Thomas Meyer 2013-09-20 7:26 ` Nicolas Ferre 0 siblings, 1 reply; 5+ messages in thread From: Thomas Meyer @ 2013-09-19 21:42 UTC (permalink / raw) To: jic23, grant.likely, rob.herring, linux-iio, linux-kernel, devicetree sizeof when applied to a pointer typed expression gives the size of the pointer. Found by coccinelle spatch "misc/noderef.cocci" Signed-off-by: Thomas Meyer <thomas@m3y3r.de> --- diff -u -p a/drivers/iio/adc/at91_adc.c b/drivers/iio/adc/at91_adc.c --- a/drivers/iio/adc/at91_adc.c +++ b/drivers/iio/adc/at91_adc.c @@ -279,7 +279,7 @@ static int at91_adc_trigger_init(struct int i, ret; st->trig = devm_kzalloc(&idev->dev, - st->trigger_number * sizeof(st->trig), + st->trigger_number * sizeof(*st->trig), GFP_KERNEL); if (st->trig == NULL) { ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 3/10] iio: at91_adc: Cocci spatch "noderef" 2013-09-19 21:42 ` [PATCH 3/10] iio: at91_adc: Cocci spatch "noderef" Thomas Meyer @ 2013-09-20 7:26 ` Nicolas Ferre 2013-09-20 18:36 ` Jonathan Cameron 0 siblings, 1 reply; 5+ messages in thread From: Nicolas Ferre @ 2013-09-20 7:26 UTC (permalink / raw) To: Thomas Meyer, jic23, grant.likely, rob.herring, linux-iio Cc: linux-kernel, devicetree On 19/09/2013 23:42, Thomas Meyer : > sizeof when applied to a pointer typed expression gives the size of the > pointer. > Found by coccinelle spatch "misc/noderef.cocci" > > Signed-off-by: Thomas Meyer <thomas@m3y3r.de> Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com> > --- > > diff -u -p a/drivers/iio/adc/at91_adc.c b/drivers/iio/adc/at91_adc.c > --- a/drivers/iio/adc/at91_adc.c > +++ b/drivers/iio/adc/at91_adc.c > @@ -279,7 +279,7 @@ static int at91_adc_trigger_init(struct > int i, ret; > > st->trig = devm_kzalloc(&idev->dev, > - st->trigger_number * sizeof(st->trig), > + st->trigger_number * sizeof(*st->trig), > GFP_KERNEL); > > if (st->trig == NULL) { > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- Nicolas Ferre ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 3/10] iio: at91_adc: Cocci spatch "noderef" 2013-09-20 7:26 ` Nicolas Ferre @ 2013-09-20 18:36 ` Jonathan Cameron 2013-09-20 18:42 ` Jonathan Cameron 0 siblings, 1 reply; 5+ messages in thread From: Jonathan Cameron @ 2013-09-20 18:36 UTC (permalink / raw) To: Nicolas Ferre Cc: Thomas Meyer, jic23, grant.likely, rob.herring, linux-iio, linux-kernel, devicetree On 09/20/13 08:26, Nicolas Ferre wrote: > On 19/09/2013 23:42, Thomas Meyer : >> sizeof when applied to a pointer typed expression gives the size of the >> pointer. >> Found by coccinelle spatch "misc/noderef.cocci" >> >> Signed-off-by: Thomas Meyer <thomas@m3y3r.de> > > Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com> Applied to the fixes-togreg branch of git://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git Thanks, > >> --- >> >> diff -u -p a/drivers/iio/adc/at91_adc.c b/drivers/iio/adc/at91_adc.c >> --- a/drivers/iio/adc/at91_adc.c >> +++ b/drivers/iio/adc/at91_adc.c >> @@ -279,7 +279,7 @@ static int at91_adc_trigger_init(struct >> int i, ret; >> >> st->trig = devm_kzalloc(&idev->dev, >> - st->trigger_number * sizeof(st->trig), >> + st->trigger_number * sizeof(*st->trig), >> GFP_KERNEL); >> >> if (st->trig == NULL) { >> -- >> To unsubscribe from this list: send the line "unsubscribe devicetree" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> > > ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 3/10] iio: at91_adc: Cocci spatch "noderef" 2013-09-20 18:36 ` Jonathan Cameron @ 2013-09-20 18:42 ` Jonathan Cameron 2013-09-23 12:16 ` Nicolas Ferre 0 siblings, 1 reply; 5+ messages in thread From: Jonathan Cameron @ 2013-09-20 18:42 UTC (permalink / raw) To: Nicolas Ferre Cc: Thomas Meyer, jic23, grant.likely, rob.herring, linux-iio, linux-kernel, devicetree On 09/20/13 19:36, Jonathan Cameron wrote: > On 09/20/13 08:26, Nicolas Ferre wrote: >> On 19/09/2013 23:42, Thomas Meyer : >>> sizeof when applied to a pointer typed expression gives the size of the >>> pointer. >>> Found by coccinelle spatch "misc/noderef.cocci" >>> >>> Signed-off-by: Thomas Meyer <thomas@m3y3r.de> >> >> Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com> > Applied to the fixes-togreg branch of > git://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git Actually, change of plan. Applied to the togreg branch of that tree. Whilst technically more correct to have it as you say, we are dealing with the size of a struct iio_trig ** vs a struct iio_trig * so it isn't actually a bug, just a less than ideal bit of code ;) It was so obviously a fix I didn't initially check if it was a 'real' bug or not. oops. Jonathan > > Thanks, >> >>> --- >>> >>> diff -u -p a/drivers/iio/adc/at91_adc.c b/drivers/iio/adc/at91_adc.c >>> --- a/drivers/iio/adc/at91_adc.c >>> +++ b/drivers/iio/adc/at91_adc.c >>> @@ -279,7 +279,7 @@ static int at91_adc_trigger_init(struct >>> int i, ret; >>> >>> st->trig = devm_kzalloc(&idev->dev, >>> - st->trigger_number * sizeof(st->trig), >>> + st->trigger_number * sizeof(*st->trig), >>> GFP_KERNEL); >>> >>> if (st->trig == NULL) { >>> -- >>> To unsubscribe from this list: send the line "unsubscribe devicetree" in >>> the body of a message to majordomo@vger.kernel.org >>> More majordomo info at http://vger.kernel.org/majordomo-info.html >>> >> >> ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 3/10] iio: at91_adc: Cocci spatch "noderef" 2013-09-20 18:42 ` Jonathan Cameron @ 2013-09-23 12:16 ` Nicolas Ferre 0 siblings, 0 replies; 5+ messages in thread From: Nicolas Ferre @ 2013-09-23 12:16 UTC (permalink / raw) To: Jonathan Cameron Cc: Thomas Meyer, jic23, grant.likely, rob.herring, linux-iio, linux-kernel, devicetree On 20/09/2013 20:42, Jonathan Cameron : > On 09/20/13 19:36, Jonathan Cameron wrote: >> On 09/20/13 08:26, Nicolas Ferre wrote: >>> On 19/09/2013 23:42, Thomas Meyer : >>>> sizeof when applied to a pointer typed expression gives the size of the >>>> pointer. >>>> Found by coccinelle spatch "misc/noderef.cocci" >>>> >>>> Signed-off-by: Thomas Meyer <thomas@m3y3r.de> >>> >>> Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com> >> Applied to the fixes-togreg branch of >> git://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git > > Actually, change of plan. Applied to the togreg branch of that > tree. Whilst technically more correct to have it as you say, > we are dealing with the size of a struct iio_trig ** vs > a struct iio_trig * so it isn't actually a bug, just a > less than ideal bit of code ;) Absolutely. > It was so obviously a fix I didn't initially check if it > was a 'real' bug or not. oops. Yes, I took this path myself as well ;-) Bye, >>>> --- >>>> >>>> diff -u -p a/drivers/iio/adc/at91_adc.c b/drivers/iio/adc/at91_adc.c >>>> --- a/drivers/iio/adc/at91_adc.c >>>> +++ b/drivers/iio/adc/at91_adc.c >>>> @@ -279,7 +279,7 @@ static int at91_adc_trigger_init(struct >>>> int i, ret; >>>> >>>> st->trig = devm_kzalloc(&idev->dev, >>>> - st->trigger_number * sizeof(st->trig), >>>> + st->trigger_number * sizeof(*st->trig), >>>> GFP_KERNEL); >>>> >>>> if (st->trig == NULL) { >>>> -- >>>> To unsubscribe from this list: send the line "unsubscribe devicetree" in >>>> the body of a message to majordomo@vger.kernel.org >>>> More majordomo info at http://vger.kernel.org/majordomo-info.html >>>> >>> >>> > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- Nicolas Ferre ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-09-23 12:16 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1379604755850-858421494-0-diffsplit-thomas@m3y3r.de>
2013-09-19 21:42 ` [PATCH 3/10] iio: at91_adc: Cocci spatch "noderef" Thomas Meyer
2013-09-20 7:26 ` Nicolas Ferre
2013-09-20 18:36 ` Jonathan Cameron
2013-09-20 18:42 ` Jonathan Cameron
2013-09-23 12:16 ` Nicolas Ferre
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).