From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from saturn.retrosnub.co.uk ([178.18.118.26]:56762 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752321Ab3IULKl (ORCPT ); Sat, 21 Sep 2013 07:10:41 -0400 Message-ID: <523D8CD5.7060007@kernel.org> Date: Sat, 21 Sep 2013 13:11:01 +0100 From: Jonathan Cameron MIME-Version: 1.0 To: Lars-Peter Clausen CC: linux-iio@vger.kernel.org Subject: Re: [PATCH 04/24] iio:ad7298: Use iio_push_to_buffers_with_timestamp() References: <1379595601-26448-1-git-send-email-lars@metafoo.de> <1379595601-26448-4-git-send-email-lars@metafoo.de> In-Reply-To: <1379595601-26448-4-git-send-email-lars@metafoo.de> Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org On 09/19/13 13:59, Lars-Peter Clausen wrote: > Makes the code a bit shorter and less ugly. > > Signed-off-by: Lars-Peter Clausen Applied to the togreg branch of iio.git > --- > drivers/iio/adc/ad7298.c | 10 ++-------- > 1 file changed, 2 insertions(+), 8 deletions(-) > > diff --git a/drivers/iio/adc/ad7298.c b/drivers/iio/adc/ad7298.c > index 0812556..2a3b65c 100644 > --- a/drivers/iio/adc/ad7298.c > +++ b/drivers/iio/adc/ad7298.c > @@ -159,20 +159,14 @@ static irqreturn_t ad7298_trigger_handler(int irq, void *p) > struct iio_poll_func *pf = p; > struct iio_dev *indio_dev = pf->indio_dev; > struct ad7298_state *st = iio_priv(indio_dev); > - s64 time_ns = 0; > int b_sent; > > b_sent = spi_sync(st->spi, &st->ring_msg); > if (b_sent) > goto done; > > - if (indio_dev->scan_timestamp) { > - time_ns = iio_get_time_ns(); > - memcpy((u8 *)st->rx_buf + indio_dev->scan_bytes - sizeof(s64), > - &time_ns, sizeof(time_ns)); > - } > - > - iio_push_to_buffers(indio_dev, st->rx_buf); > + iio_push_to_buffers_with_timestamp(indio_dev, st->rx_buf, > + iio_get_time_ns()); > > done: > iio_trigger_notify_done(indio_dev->trig); >