From: Jonathan Cameron <jic23@kernel.org>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: linux-iio@vger.kernel.org, Ge Gao <ggao@invensense.com>
Subject: Re: [PATCH 15/24] iio:mpu6050: Use iio_push_to_buffers_with_timestamp()
Date: Sat, 21 Sep 2013 13:16:08 +0100 [thread overview]
Message-ID: <523D8E08.9090306@kernel.org> (raw)
In-Reply-To: <1379595601-26448-15-git-send-email-lars@metafoo.de>
On 09/19/13 13:59, Lars-Peter Clausen wrote:
> Makes the code a bit shorter and less ugly.
>
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
> Cc: Ge Gao <ggao@invensense.com>
Applied to the togreg branch of iio.git
> ---
> drivers/iio/imu/inv_mpu6050/inv_mpu_ring.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/iio/imu/inv_mpu6050/inv_mpu_ring.c b/drivers/iio/imu/inv_mpu6050/inv_mpu_ring.c
> index 7da0832..4295171 100644
> --- a/drivers/iio/imu/inv_mpu6050/inv_mpu_ring.c
> +++ b/drivers/iio/imu/inv_mpu6050/inv_mpu_ring.c
> @@ -124,7 +124,6 @@ irqreturn_t inv_mpu6050_read_fifo(int irq, void *p)
> u8 data[INV_MPU6050_OUTPUT_DATA_SIZE];
> u16 fifo_count;
> s64 timestamp;
> - u64 *tmp;
>
> mutex_lock(&indio_dev->mlock);
> if (!(st->chip_config.accl_fifo_enable |
> @@ -170,9 +169,8 @@ irqreturn_t inv_mpu6050_read_fifo(int irq, void *p)
> if (0 == result)
> timestamp = 0;
>
> - tmp = (u64 *)data;
> - tmp[DIV_ROUND_UP(bytes_per_datum, 8)] = timestamp;
> - result = iio_push_to_buffers(indio_dev, data);
> + result = iio_push_to_buffers_with_timestamp(indio_dev, data,
> + timestamp);
> if (result)
> goto flush_fifo;
> fifo_count -= bytes_per_datum;
>
next prev parent reply other threads:[~2013-09-21 11:15 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-19 12:59 [PATCH 01/24] iio: Add iio_push_buffers_with_timestamp() helper Lars-Peter Clausen
2013-09-19 12:59 ` [PATCH 02/24] iio:bma180: Use iio_push_buffers_with_timestamp() Lars-Peter Clausen
2013-09-21 12:08 ` Jonathan Cameron
2013-09-19 12:59 ` [PATCH 03/24] iio:ad7266: Use iio_push_to_buffers_with_timestamp() Lars-Peter Clausen
2013-09-21 12:10 ` Jonathan Cameron
2013-09-19 12:59 ` [PATCH 04/24] iio:ad7298: " Lars-Peter Clausen
2013-09-21 12:11 ` Jonathan Cameron
2013-09-19 12:59 ` [PATCH 05/24] iio:ad7476: " Lars-Peter Clausen
2013-09-21 12:11 ` Jonathan Cameron
2013-09-19 12:59 ` [PATCH 06/24] iio:ad7887: " Lars-Peter Clausen
2013-09-21 12:11 ` Jonathan Cameron
2013-09-19 12:59 ` [PATCH 07/24] iio:ad7923: " Lars-Peter Clausen
2013-09-21 12:12 ` Jonathan Cameron
2013-09-19 12:59 ` [PATCH 08/24] iio:ad_sigma_delta: " Lars-Peter Clausen
2013-09-21 12:12 ` Jonathan Cameron
2013-09-19 12:59 ` [PATCH 09/24] iio:at91_adc: " Lars-Peter Clausen
2013-09-21 12:12 ` Jonathan Cameron
2013-09-19 12:59 ` [PATCH 10/24] iio:max1363: " Lars-Peter Clausen
2013-09-21 12:13 ` Jonathan Cameron
2013-09-19 12:59 ` [PATCH 11/24] iio:st_sensors: " Lars-Peter Clausen
2013-09-21 12:13 ` Jonathan Cameron
2013-09-19 12:59 ` [PATCH 12/24] iio:itg3200: " Lars-Peter Clausen
2013-09-21 12:14 ` Jonathan Cameron
2013-09-19 12:59 ` [PATCH 13/24] iio:adis16400: " Lars-Peter Clausen
2013-09-21 12:15 ` Jonathan Cameron
2013-09-19 12:59 ` [PATCH 14/24] iio:adis_lib: " Lars-Peter Clausen
2013-09-21 12:15 ` Jonathan Cameron
2013-09-19 12:59 ` [PATCH 15/24] iio:mpu6050: " Lars-Peter Clausen
2013-09-21 12:16 ` Jonathan Cameron [this message]
2013-09-19 12:59 ` [PATCH 16/24] iio:adjd_s311: " Lars-Peter Clausen
2013-09-21 12:16 ` Jonathan Cameron
2013-09-19 12:59 ` [PATCH 17/24] iio:tcs3472: " Lars-Peter Clausen
2013-09-21 12:17 ` Jonathan Cameron
2013-09-19 12:59 ` [PATCH 18/24] iio:gp2ap020a00f: " Lars-Peter Clausen
2013-09-21 12:17 ` Jonathan Cameron
2013-09-19 12:59 ` [PATCH 19/24] staging:iio:lis3l02dq: " Lars-Peter Clausen
2013-09-21 12:18 ` Jonathan Cameron
2013-09-19 12:59 ` [PATCH 20/24] staging:iio:ad7606: " Lars-Peter Clausen
2013-09-21 12:18 ` Jonathan Cameron
2013-09-19 12:59 ` [PATCH 21/24] staging:iio:ad799x: " Lars-Peter Clausen
2013-09-21 12:19 ` Jonathan Cameron
2013-09-19 12:59 ` [PATCH 22/24] staging:iio:mxs-lradc: " Lars-Peter Clausen
2013-09-21 12:19 ` Jonathan Cameron
2013-09-19 13:00 ` [PATCH 23/24] staging:iio:dummy: " Lars-Peter Clausen
2013-09-21 12:19 ` Jonathan Cameron
2013-09-19 13:00 ` [PATCH 24/24] staging:iio:ade7758: " Lars-Peter Clausen
2013-09-21 12:20 ` Jonathan Cameron
2013-09-21 12:08 ` [PATCH 01/24] iio: Add iio_push_buffers_with_timestamp() helper Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=523D8E08.9090306@kernel.org \
--to=jic23@kernel.org \
--cc=ggao@invensense.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).