* [PATCH] iio: dac: ad5446: Add support for AD5641
@ 2013-09-23 13:04 Aida Mynzhasova
2013-09-23 13:30 ` Lars-Peter Clausen
2013-09-23 13:47 ` Axel Lin
0 siblings, 2 replies; 3+ messages in thread
From: Aida Mynzhasova @ 2013-09-23 13:04 UTC (permalink / raw)
To: ic23; +Cc: lars, linux-iio, axel.lin, gregkh
This patch adds support for the AD5641 single channel,
14-bit, buffered voltage output DAC.
Signed-off-by: Aida Mynzhasova <aida.mynzhasova@skitlab.ru>
---
drivers/iio/dac/Kconfig | 2 +-
drivers/iio/dac/ad5446.c | 6 ++++++
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/iio/dac/Kconfig b/drivers/iio/dac/Kconfig
index c9c33ce..cede548 100644
--- a/drivers/iio/dac/Kconfig
+++ b/drivers/iio/dac/Kconfig
@@ -62,7 +62,7 @@ config AD5446
Say yes here to build support for Analog Devices AD5300, AD5301, AD5310,
AD5311, AD5320, AD5321, AD5444, AD5446, AD5450, AD5451, AD5452, AD5453,
AD5512A, AD5541A, AD5542A, AD5543, AD5553, AD5601, AD5602, AD5611, AD5612,
- AD5620, AD5621, AD5622, AD5640, AD5660, AD5662 DACs.
+ AD5620, AD5621, AD5641, AD5622, AD5640, AD5660, AD5662 DACs.
To compile this driver as a module, choose M here: the
module will be called ad5446.
diff --git a/drivers/iio/dac/ad5446.c b/drivers/iio/dac/ad5446.c
index cae8f60..b543d09 100644
--- a/drivers/iio/dac/ad5446.c
+++ b/drivers/iio/dac/ad5446.c
@@ -338,6 +338,7 @@ enum ad5446_supported_spi_device_ids {
ID_AD5601,
ID_AD5611,
ID_AD5621,
+ ID_AD5641,
ID_AD5620_2500,
ID_AD5620_1250,
ID_AD5640_2500,
@@ -400,6 +401,10 @@ static const struct ad5446_chip_info ad5446_spi_chip_info[] = {
.channel = AD5446_CHANNEL_POWERDOWN(12, 16, 2),
.write = ad5446_write,
},
+ [ID_AD5641] = {
+ .channel = AD5446_CHANNEL_POWERDOWN(14, 16, 0),
+ .write = ad5446_write,
+ },
[ID_AD5620_2500] = {
.channel = AD5446_CHANNEL_POWERDOWN(12, 16, 2),
.int_vref_mv = 2500,
@@ -454,6 +459,7 @@ static const struct spi_device_id ad5446_spi_ids[] = {
{"ad5601", ID_AD5601},
{"ad5611", ID_AD5611},
{"ad5621", ID_AD5621},
+ {"ad5641", ID_AD5641},
{"ad5620-2500", ID_AD5620_2500}, /* AD5620/40/60: */
{"ad5620-1250", ID_AD5620_1250}, /* part numbers may look differently */
{"ad5640-2500", ID_AD5640_2500},
--
1.8.1.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] iio: dac: ad5446: Add support for AD5641
2013-09-23 13:04 [PATCH] iio: dac: ad5446: Add support for AD5641 Aida Mynzhasova
@ 2013-09-23 13:30 ` Lars-Peter Clausen
2013-09-23 13:47 ` Axel Lin
1 sibling, 0 replies; 3+ messages in thread
From: Lars-Peter Clausen @ 2013-09-23 13:30 UTC (permalink / raw)
To: Aida Mynzhasova; +Cc: ic23, linux-iio, axel.lin, gregkh
On 09/23/2013 03:04 PM, Aida Mynzhasova wrote:
> This patch adds support for the AD5641 single channel,
> 14-bit, buffered voltage output DAC.
>
> Signed-off-by: Aida Mynzhasova <aida.mynzhasova@skitlab.ru>
Reviewed-by: Lars-Peter Clausen <lars@metafoo.de>
Thanks for the patch.
> ---
> drivers/iio/dac/Kconfig | 2 +-
> drivers/iio/dac/ad5446.c | 6 ++++++
> 2 files changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iio/dac/Kconfig b/drivers/iio/dac/Kconfig
> index c9c33ce..cede548 100644
> --- a/drivers/iio/dac/Kconfig
> +++ b/drivers/iio/dac/Kconfig
> @@ -62,7 +62,7 @@ config AD5446
> Say yes here to build support for Analog Devices AD5300, AD5301, AD5310,
> AD5311, AD5320, AD5321, AD5444, AD5446, AD5450, AD5451, AD5452, AD5453,
> AD5512A, AD5541A, AD5542A, AD5543, AD5553, AD5601, AD5602, AD5611, AD5612,
> - AD5620, AD5621, AD5622, AD5640, AD5660, AD5662 DACs.
> + AD5620, AD5621, AD5641, AD5622, AD5640, AD5660, AD5662 DACs.
Jonathan can you fix up the alphabetical order here when you apply the
patch? Thanks.
>
> To compile this driver as a module, choose M here: the
> module will be called ad5446.
> diff --git a/drivers/iio/dac/ad5446.c b/drivers/iio/dac/ad5446.c
> index cae8f60..b543d09 100644
> --- a/drivers/iio/dac/ad5446.c
> +++ b/drivers/iio/dac/ad5446.c
> @@ -338,6 +338,7 @@ enum ad5446_supported_spi_device_ids {
> ID_AD5601,
> ID_AD5611,
> ID_AD5621,
> + ID_AD5641,
> ID_AD5620_2500,
> ID_AD5620_1250,
> ID_AD5640_2500,
> @@ -400,6 +401,10 @@ static const struct ad5446_chip_info ad5446_spi_chip_info[] = {
> .channel = AD5446_CHANNEL_POWERDOWN(12, 16, 2),
> .write = ad5446_write,
> },
> + [ID_AD5641] = {
> + .channel = AD5446_CHANNEL_POWERDOWN(14, 16, 0),
> + .write = ad5446_write,
> + },
> [ID_AD5620_2500] = {
> .channel = AD5446_CHANNEL_POWERDOWN(12, 16, 2),
> .int_vref_mv = 2500,
> @@ -454,6 +459,7 @@ static const struct spi_device_id ad5446_spi_ids[] = {
> {"ad5601", ID_AD5601},
> {"ad5611", ID_AD5611},
> {"ad5621", ID_AD5621},
> + {"ad5641", ID_AD5641},
> {"ad5620-2500", ID_AD5620_2500}, /* AD5620/40/60: */
> {"ad5620-1250", ID_AD5620_1250}, /* part numbers may look differently */
> {"ad5640-2500", ID_AD5640_2500},
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] iio: dac: ad5446: Add support for AD5641
2013-09-23 13:04 [PATCH] iio: dac: ad5446: Add support for AD5641 Aida Mynzhasova
2013-09-23 13:30 ` Lars-Peter Clausen
@ 2013-09-23 13:47 ` Axel Lin
1 sibling, 0 replies; 3+ messages in thread
From: Axel Lin @ 2013-09-23 13:47 UTC (permalink / raw)
To: Aida Mynzhasova; +Cc: ic23, Lars-Peter Clausen, linux-iio, Greg Kroah-Hartman
2013/9/23 Aida Mynzhasova <aida.mynzhasova@skitlab.ru>:
> This patch adds support for the AD5641 single channel,
> 14-bit, buffered voltage output DAC.
>
> Signed-off-by: Aida Mynzhasova <aida.mynzhasova@skitlab.ru>
> ---
> drivers/iio/dac/Kconfig | 2 +-
> drivers/iio/dac/ad5446.c | 6 ++++++
> 2 files changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iio/dac/Kconfig b/drivers/iio/dac/Kconfig
> index c9c33ce..cede548 100644
> --- a/drivers/iio/dac/Kconfig
> +++ b/drivers/iio/dac/Kconfig
> @@ -62,7 +62,7 @@ config AD5446
> Say yes here to build support for Analog Devices AD5300, AD5301, AD5310,
> AD5311, AD5320, AD5321, AD5444, AD5446, AD5450, AD5451, AD5452, AD5453,
> AD5512A, AD5541A, AD5542A, AD5543, AD5553, AD5601, AD5602, AD5611, AD5612,
> - AD5620, AD5621, AD5622, AD5640, AD5660, AD5662 DACs.
> + AD5620, AD5621, AD5641, AD5622, AD5640, AD5660, AD5662 DACs.
This driver has sorted the ID in proper order so you should put AD5641 after
AD5640. (This comment also applies for all below changes).
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-09-23 13:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-23 13:04 [PATCH] iio: dac: ad5446: Add support for AD5641 Aida Mynzhasova
2013-09-23 13:30 ` Lars-Peter Clausen
2013-09-23 13:47 ` Axel Lin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).