From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Matthias Kaehlcke <matthias.list@kaehlcke.net>,
Jonathan Cameron <jic23@cam.ac.uk>,
"Patil, Rachna" <rachna@ti.com>, Felipe Balbi <balbi@ti.com>,
Pantelis Antoniou <panto@antoniou-consulting.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] iio: ti_am335x_adc: Take touchscreen channels into account for conversion timeout
Date: Mon, 23 Sep 2013 15:31:14 +0200 [thread overview]
Message-ID: <524042A2.2070005@linutronix.de> (raw)
In-Reply-To: <20130910210228.GC30481@raspi>
On 09/10/2013 11:02 PM, Matthias Kaehlcke wrote:
> The calculation of the old conversion timeout value was based on the number of
> channels used by this driver. This doesn't take into account that other channels
> can be used by the touchscreen driver. Adjust the timeout value to the maximum
> if the touchscreen driver is enabled
What bug / miss behave are you trying to fix?
The difference in timming is minimal and therefore I would prefer to get
rid of this ifdef and assume the max value of those two instead.
Sebastian
next prev parent reply other threads:[~2013-09-23 13:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <f1830a7d0debce351966d2f3232158313d87dcc0.1378846446.git.matthias@kaehlcke.net>
2013-09-10 21:02 ` [PATCH 2/2] iio: ti_am335x_adc: Take touchscreen channels into account for conversion timeout Matthias Kaehlcke
2013-09-15 16:17 ` Jonathan Cameron
2013-09-15 16:52 ` Jonathan Cameron
2013-09-15 17:50 ` Matthias Kaehlcke
2013-09-23 13:31 ` Sebastian Andrzej Siewior [this message]
2013-09-23 16:46 ` Matthias Kaehlcke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=524042A2.2070005@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=balbi@ti.com \
--cc=jic23@cam.ac.uk \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthias.list@kaehlcke.net \
--cc=panto@antoniou-consulting.com \
--cc=rachna@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).