* [PATCH] staging:iio:iio-trig-bfin-timer: Fix compile error
@ 2013-09-27 13:50 Lars-Peter Clausen
2013-09-28 10:46 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Lars-Peter Clausen @ 2013-09-27 13:50 UTC (permalink / raw)
To: Jonathan Cameron; +Cc: linux-iio, Lars-Peter Clausen
This patch fixes the following compile errors for the iio-trig-bfin-timer
driver:
drivers/staging/iio/trigger/iio-trig-bfin-timer.c: In function ‘iio_bfin_tmr_frequency_store’:
drivers/staging/iio/trigger/iio-trig-bfin-timer.c:121: error: invalid storage class for function ‘iio_bfin_tmr_frequency_show’
drivers/staging/iio/trigger/iio-trig-bfin-timer.c:118: warning: ISO C90 forbids mixed declarations and code
drivers/staging/iio/trigger/iio-trig-bfin-timer.c:135: error: initializer element is not constant
...
The issue was introduced in commit e5e26dd5 ("staging: iio: replace
strict_strto*() with kstrto*()") by leaving an excess opening bracket.
Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
---
drivers/staging/iio/trigger/iio-trig-bfin-timer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/iio/trigger/iio-trig-bfin-timer.c b/drivers/staging/iio/trigger/iio-trig-bfin-timer.c
index ebb189c..26e1ca0 100644
--- a/drivers/staging/iio/trigger/iio-trig-bfin-timer.c
+++ b/drivers/staging/iio/trigger/iio-trig-bfin-timer.c
@@ -91,7 +91,7 @@ static ssize_t iio_bfin_tmr_frequency_store(struct device *dev,
if (ret)
return ret;
- if (val > 100000) {
+ if (val > 100000)
return -EINVAL;
enabled = get_enabled_gptimers() & st->t->bit;
--
1.8.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging:iio:iio-trig-bfin-timer: Fix compile error
2013-09-27 13:50 [PATCH] staging:iio:iio-trig-bfin-timer: Fix compile error Lars-Peter Clausen
@ 2013-09-28 10:46 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2013-09-28 10:46 UTC (permalink / raw)
To: Lars-Peter Clausen; +Cc: linux-iio
On 09/27/13 14:50, Lars-Peter Clausen wrote:
> This patch fixes the following compile errors for the iio-trig-bfin-timer
> driver:
> drivers/staging/iio/trigger/iio-trig-bfin-timer.c: In function ‘iio_bfin_tmr_frequency_store’:
> drivers/staging/iio/trigger/iio-trig-bfin-timer.c:121: error: invalid storage class for function ‘iio_bfin_tmr_frequency_show’
> drivers/staging/iio/trigger/iio-trig-bfin-timer.c:118: warning: ISO C90 forbids mixed declarations and code
> drivers/staging/iio/trigger/iio-trig-bfin-timer.c:135: error: initializer element is not constant
> ...
>
> The issue was introduced in commit e5e26dd5 ("staging: iio: replace
> strict_strto*() with kstrto*()") by leaving an excess opening bracket.
>
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Applied to the togreg branch of iio.git
Thanks,
> ---
> drivers/staging/iio/trigger/iio-trig-bfin-timer.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/iio/trigger/iio-trig-bfin-timer.c b/drivers/staging/iio/trigger/iio-trig-bfin-timer.c
> index ebb189c..26e1ca0 100644
> --- a/drivers/staging/iio/trigger/iio-trig-bfin-timer.c
> +++ b/drivers/staging/iio/trigger/iio-trig-bfin-timer.c
> @@ -91,7 +91,7 @@ static ssize_t iio_bfin_tmr_frequency_store(struct device *dev,
> if (ret)
> return ret;
>
> - if (val > 100000) {
> + if (val > 100000)
> return -EINVAL;
>
> enabled = get_enabled_gptimers() & st->t->bit;
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-09-28 9:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-27 13:50 [PATCH] staging:iio:iio-trig-bfin-timer: Fix compile error Lars-Peter Clausen
2013-09-28 10:46 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).