Re: [PATCH v3 2/2] DT: Add documentation for cm36651 proximity/light sensor

[Jonathan Cameron <jic23@kernel.org>]

On 09/26/13 05:17, Beomho Seo wrote:
> 
> This patch add device tree binding documentation for CM36651 proximity/ light sensor.
> 
> Signed-off-by: Beomho Seo <beomho.seo@samsung.com>
> ---
>  .../devicetree/bindings/iio/light/cm36651.txt      |   25 ++++++++++++++++++++
>  .../devicetree/bindings/vendor-prefixes.txt        |    1 +
>  2 files changed, 26 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/iio/light/cm36651.txt
> 
> diff --git a/Documentation/devicetree/bindings/iio/light/cm36651.txt b/Documentation/devicetree/bindings/iio/light/cm36651.txt
> new file mode 100644
> index 0000000..5d75a2b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/light/cm36651.txt
> @@ -0,0 +1,25 @@
> +* Capella CM36651 I2C Proximity and Color Light sensor
> +
> +Required properties:
> +- compatible: must be "capella,cm36651"
> +- reg: the I2C address of the device
> +- interrupts: interrupt-specifier for the sole interrupt
> +	      generated by the device
> +- vled-supply: regulator for the sensor device, as covered
> +	       in ../../regulator/regulator.txt
Mark brought this up before...
The description needs to mention this if for an LED associated
with (or integrated in?) the device, used exclusively for proximity
detection.

> +
> +Example:
> +
> +	i2c_cm36651: i2c-gpio {
> +		/* ... */
> +
> +		cm36651@18 {
> +			compatible = "capella,cm36651";
> +			reg = <0x18>;
> +			interrupt-parent = <&gpx0>;
> +			interrupts = <2 0>;
> +			vled-supply = <&ps_als_reg>;
> +		};
> +
> +		/* ... */
> +	};
> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
> index 2956800..04eab45 100644
> --- a/Documentation/devicetree/bindings/vendor-prefixes.txt
> +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
> @@ -15,6 +15,7 @@ atmel	Atmel Corporation
>  avago	Avago Technologies
>  bosch	Bosch Sensortec GmbH
>  brcm	Broadcom Corporation
> +capella	Capella Microsystems, Inc
>  cavium	Cavium, Inc.
>  chrp	Common Hardware Reference Platform
>  cirrus	Cirrus Logic, Inc.
>