From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from saturn.retrosnub.co.uk ([178.18.118.26]:51504 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751564Ab3JAHvE (ORCPT ); Tue, 1 Oct 2013 03:51:04 -0400 Message-ID: <524A8D13.3050406@kernel.org> Date: Tue, 01 Oct 2013 09:51:31 +0100 From: Jonathan Cameron MIME-Version: 1.0 To: Lars-Peter Clausen CC: linux-iio@vger.kernel.org Subject: Re: [PATCH 05/25] iio:ad5446: Report scale as fractional value References: <1380360717-26103-1-git-send-email-lars@metafoo.de> <1380360717-26103-5-git-send-email-lars@metafoo.de> In-Reply-To: <1380360717-26103-5-git-send-email-lars@metafoo.de> Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org On 09/28/13 10:31, Lars-Peter Clausen wrote: > Move the complexity of calculating the fixed point scale to the core. > > Signed-off-by: Lars-Peter Clausen Applied to the togreg branch of iio.git Thanks, > --- > drivers/iio/dac/ad5446.c | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/drivers/iio/dac/ad5446.c b/drivers/iio/dac/ad5446.c > index 6dcb6d9..cb72f01 100644 > --- a/drivers/iio/dac/ad5446.c > +++ b/drivers/iio/dac/ad5446.c > @@ -163,18 +163,15 @@ static int ad5446_read_raw(struct iio_dev *indio_dev, > long m) > { > struct ad5446_state *st = iio_priv(indio_dev); > - unsigned long scale_uv; > > switch (m) { > case IIO_CHAN_INFO_RAW: > *val = st->cached_val; > return IIO_VAL_INT; > case IIO_CHAN_INFO_SCALE: > - scale_uv = (st->vref_mv * 1000) >> chan->scan_type.realbits; > - *val = scale_uv / 1000; > - *val2 = (scale_uv % 1000) * 1000; > - return IIO_VAL_INT_PLUS_MICRO; > - > + *val = st->vref_mv; > + *val2 = chan->scan_type.realbits; > + return IIO_VAL_FRACTIONAL_LOG2; > } > return -EINVAL; > } >