From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from saturn.retrosnub.co.uk ([178.18.118.26]:51729 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751769Ab3JAIFm (ORCPT ); Tue, 1 Oct 2013 04:05:42 -0400 Message-ID: <524A9081.4020203@kernel.org> Date: Tue, 01 Oct 2013 10:06:09 +0100 From: Jonathan Cameron MIME-Version: 1.0 To: Lars-Peter Clausen CC: linux-iio@vger.kernel.org Subject: Re: [PATCH 15/25] iio:ad7476: Report scale as fractional value References: <1380360717-26103-1-git-send-email-lars@metafoo.de> <1380360717-26103-15-git-send-email-lars@metafoo.de> In-Reply-To: <1380360717-26103-15-git-send-email-lars@metafoo.de> Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org On 09/28/13 10:31, Lars-Peter Clausen wrote: > Move the complexity of calculating the fixed point scale to the core. > > Signed-off-by: Lars-Peter Clausen Applied to the togreg branch of iio.git Thanks, > --- > drivers/iio/adc/ad7476.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/drivers/iio/adc/ad7476.c b/drivers/iio/adc/ad7476.c > index 8d808b9..d141d45 100644 > --- a/drivers/iio/adc/ad7476.c > +++ b/drivers/iio/adc/ad7476.c > @@ -127,10 +127,9 @@ static int ad7476_read_raw(struct iio_dev *indio_dev, > } else { > scale_uv = st->chip_info->int_vref_uv; > } > - scale_uv >>= chan->scan_type.realbits; > - *val = scale_uv / 1000; > - *val2 = (scale_uv % 1000) * 1000; > - return IIO_VAL_INT_PLUS_MICRO; > + *val = scale_uv / 1000; > + *val2 = chan->scan_type.realbits; > + return IIO_VAL_FRACTIONAL_LOG2; > } > return -EINVAL; > } >