From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-iio-owner@vger.kernel.org>
Received: from saturn.retrosnub.co.uk ([178.18.118.26]:34663 "EHLO
	saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750881Ab3JAU0s (ORCPT
	<rfc822;linux-iio@vger.kernel.org>); Tue, 1 Oct 2013 16:26:48 -0400
Message-ID: <524B3E32.1000809@kernel.org>
Date: Tue, 01 Oct 2013 22:27:14 +0100
From: Jonathan Cameron <jic23@kernel.org>
MIME-Version: 1.0
To: Beomho Seo <beomho.seo@samsung.com>,
	"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>
CC: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"rob.herring@calxeda.com" <rob.herring@calxeda.com>,
	pawel.moll@arm.com, Mark Rutland <mark.rutland@arm.com>,
	"ian.campbell@citrix.com" <ian.campbell@citrix.com>,
	Sylwester Nawrocki <s.nawrocki@samsung.com>,
	Jacek Anaszewski <j.anaszewski@samsung.com>,
	myungjoo.ham@samsung.com, Jaehoon Chung <jh80.chung@samsung.com>,
	Peter Meerwald l <pmeerw@pmeerw.net>
Subject: Re: [PATCH v5 2/2] DT: Add documentation for cm36651 proximity/light
 sensor
References: <524AC65E.8030407@samsung.com>
In-Reply-To: <524AC65E.8030407@samsung.com>
Content-Type: text/plain; charset=UTF-8
Sender: linux-iio-owner@vger.kernel.org
List-Id: linux-iio@vger.kernel.org

On 10/01/13 13:55, Beomho Seo wrote:
> 
> This patch adds device tree binding documentation for CM36651 proximity/light sensor.
> 
> Signed-off-by: Beomho Seo <beomho.seo@samsung.com>
> ---
>  .../devicetree/bindings/iio/light/cm36651.txt      |   26 ++++++++++++++++++++
>  .../devicetree/bindings/vendor-prefixes.txt        |    1 +
>  2 files changed, 27 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/iio/light/cm36651.txt
> 
> diff --git a/Documentation/devicetree/bindings/iio/light/cm36651.txt b/Documentation/devicetree/bindings/iio/light/cm36651.txt
> new file mode 100644
> index 0000000..3dd4efb
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/light/cm36651.txt
> @@ -0,0 +1,26 @@
> +* Capella CM36651 I2C Proximity and Color Light sensor
> +
> +Required properties:
> +- compatible: must be "capella,cm36651"
> +- reg: the I2C address of the device
> +- interrupts: interrupt-specifier for the sole interrupt
> +	      generated by the device
> +- vled-supply: regulator for the IR LED. IR_LED is a part
> +	      of the cm36651 for proximity detection.
> +	      as covered in ../../regulator/regulator.txt
Trivial but:
As covered in
> +
> +Example:
> +
> +	i2c_cm36651: i2c-gpio {
> +		/* ... */
> +
> +		cm36651@18 {
> +			compatible = "capella,cm36651";
> +			reg = <0x18>;
> +			interrupt-parent = <&gpx0>;
> +			interrupts = <2 0>;
> +			vled-supply = <&ps_als_reg>;
> +		};
> +
> +		/* ... */
> +	};
> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
> index 2956800..04eab45 100644
> --- a/Documentation/devicetree/bindings/vendor-prefixes.txt
> +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
> @@ -15,6 +15,7 @@ atmel	Atmel Corporation
>  avago	Avago Technologies
>  bosch	Bosch Sensortec GmbH
>  brcm	Broadcom Corporation
> +capella	Capella Microsystems, Inc
>  cavium	Cavium, Inc.
>  chrp	Common Hardware Reference Platform
>  cirrus	Cirrus Logic, Inc.
>