From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from saturn.retrosnub.co.uk ([178.18.118.26]:32923 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751408Ab3JEKAa (ORCPT ); Sat, 5 Oct 2013 06:00:30 -0400 Message-ID: <524FF16E.7090408@kernel.org> Date: Sat, 05 Oct 2013 12:01:02 +0100 From: Jonathan Cameron MIME-Version: 1.0 To: Lars-Peter Clausen CC: linux-iio@vger.kernel.org Subject: Re: [PATCH 5/8] staging:iio:adis16220: Use spi_sync_transfer() References: <1380959108-21775-1-git-send-email-lars@metafoo.de> <1380959108-21775-5-git-send-email-lars@metafoo.de> In-Reply-To: <1380959108-21775-5-git-send-email-lars@metafoo.de> Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org On 10/05/13 08:45, Lars-Peter Clausen wrote: > Use the spi_sync_transfer() helper function instead of open-coding it. Makes > the code a bit shorter. > > Signed-off-by: Lars-Peter Clausen Applied > --- > drivers/staging/iio/accel/adis16220_core.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/drivers/staging/iio/accel/adis16220_core.c b/drivers/staging/iio/accel/adis16220_core.c > index 5c28961..4c9364b 100644 > --- a/drivers/staging/iio/accel/adis16220_core.c > +++ b/drivers/staging/iio/accel/adis16220_core.c > @@ -102,7 +102,6 @@ static ssize_t adis16220_capture_buffer_read(struct iio_dev *indio_dev, > int addr) > { > struct adis16220_state *st = iio_priv(indio_dev); > - struct spi_message msg; > struct spi_transfer xfers[] = { > { > .tx_buf = st->tx, > @@ -147,10 +146,7 @@ static ssize_t adis16220_capture_buffer_read(struct iio_dev *indio_dev, > } > xfers[1].len = count; > > - spi_message_init(&msg); > - spi_message_add_tail(&xfers[0], &msg); > - spi_message_add_tail(&xfers[1], &msg); > - ret = spi_sync(st->adis.spi, &msg); > + ret = spi_sync_transfer(st->adis.spi, xfers, ARRAY_SIZE(xfers)); > if (ret) { > > mutex_unlock(&st->buf_lock); >