From: Jonathan Cameron <jic23@kernel.org>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: linux-iio@vger.kernel.org
Subject: Re: [PATCH 8/8] staging:iio:ad9951: Use spi_sync_transfer()
Date: Sat, 05 Oct 2013 12:02:14 +0100 [thread overview]
Message-ID: <524FF1B6.2040804@kernel.org> (raw)
In-Reply-To: <1380959108-21775-8-git-send-email-lars@metafoo.de>
On 10/05/13 08:45, Lars-Peter Clausen wrote:
> Use the spi_sync_transfer() helper function instead of open-coding it. Makes the
> code a bit shorter.
>
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Applied. Thanks,
> ---
> drivers/staging/iio/frequency/ad9951.c | 26 ++++++--------------------
> 1 file changed, 6 insertions(+), 20 deletions(-)
>
> diff --git a/drivers/staging/iio/frequency/ad9951.c b/drivers/staging/iio/frequency/ad9951.c
> index 0094c2f..5e8990a 100644
> --- a/drivers/staging/iio/frequency/ad9951.c
> +++ b/drivers/staging/iio/frequency/ad9951.c
> @@ -60,7 +60,6 @@ static ssize_t ad9951_set_parameter(struct device *dev,
> const char *buf,
> size_t len)
> {
> - struct spi_message msg;
> struct spi_transfer xfer;
> int ret;
> struct ad9951_config *config = (struct ad9951_config *)buf;
> @@ -71,36 +70,28 @@ static ssize_t ad9951_set_parameter(struct device *dev,
> xfer.tx_buf = &config->asf[0];
> mutex_lock(&st->lock);
>
> - spi_message_init(&msg);
> - spi_message_add_tail(&xfer, &msg);
> - ret = spi_sync(st->sdev, &msg);
> + ret = spi_sync_transfer(st->sdev, &xfer, 1);
> if (ret)
> goto error_ret;
>
> xfer.len = 2;
> xfer.tx_buf = &config->arr[0];
>
> - spi_message_init(&msg);
> - spi_message_add_tail(&xfer, &msg);
> - ret = spi_sync(st->sdev, &msg);
> + ret = spi_sync_transfer(st->sdev, &xfer, 1);
> if (ret)
> goto error_ret;
>
> xfer.len = 5;
> xfer.tx_buf = &config->ftw0[0];
>
> - spi_message_init(&msg);
> - spi_message_add_tail(&xfer, &msg);
> - ret = spi_sync(st->sdev, &msg);
> + ret = spi_sync_transfer(st->sdev, &xfer, 1);
> if (ret)
> goto error_ret;
>
> xfer.len = 3;
> xfer.tx_buf = &config->ftw1[0];
>
> - spi_message_init(&msg);
> - spi_message_add_tail(&xfer, &msg);
> - ret = spi_sync(st->sdev, &msg);
> + ret = spi_sync_transfer(st->sdev, &xfer, 1);
> if (ret)
> goto error_ret;
> error_ret:
> @@ -113,7 +104,6 @@ static IIO_DEVICE_ATTR(dds, S_IWUSR, NULL, ad9951_set_parameter, 0);
>
> static void ad9951_init(struct ad9951_state *st)
> {
> - struct spi_message msg;
> struct spi_transfer xfer;
> int ret;
> u8 cfr[5];
> @@ -129,9 +119,7 @@ static void ad9951_init(struct ad9951_state *st)
> xfer.len = 5;
> xfer.tx_buf = 𝔠
>
> - spi_message_init(&msg);
> - spi_message_add_tail(&xfer, &msg);
> - ret = spi_sync(st->sdev, &msg);
> + ret = spi_sync_transfer(st->sdev, &xfer, 1);
> if (ret)
> goto error_ret;
>
> @@ -143,9 +131,7 @@ static void ad9951_init(struct ad9951_state *st)
> xfer.len = 4;
> xfer.tx_buf = 𝔠
>
> - spi_message_init(&msg);
> - spi_message_add_tail(&xfer, &msg);
> - ret = spi_sync(st->sdev, &msg);
> + ret = spi_sync_transfer(st->sdev, &xfer, 1);
> if (ret)
> goto error_ret;
>
>
next prev parent reply other threads:[~2013-10-05 10:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-05 7:45 [PATCH 1/8] iio:ad5449: Use spi_sync_transfer() Lars-Peter Clausen
2013-10-05 7:45 ` [PATCH 2/8] iio:adis16080: " Lars-Peter Clausen
2013-10-05 10:59 ` Jonathan Cameron
2013-10-05 7:45 ` [PATCH 3/8] iio:adxrs450: " Lars-Peter Clausen
2013-10-05 10:59 ` Jonathan Cameron
2013-10-05 7:45 ` [PATCH 4/8] iio:adis16130: " Lars-Peter Clausen
2013-10-05 11:00 ` Jonathan Cameron
2013-10-05 11:00 ` Jonathan Cameron
2013-10-05 7:45 ` [PATCH 5/8] staging:iio:adis16220: " Lars-Peter Clausen
2013-10-05 11:01 ` Jonathan Cameron
2013-10-05 7:45 ` [PATCH 6/8] staging:iio:ad9852: " Lars-Peter Clausen
2013-10-05 11:01 ` Jonathan Cameron
2013-10-05 7:45 ` [PATCH 7/8] staging:iio:ad9910: " Lars-Peter Clausen
2013-10-05 11:01 ` Jonathan Cameron
2013-10-05 7:45 ` [PATCH 8/8] staging:iio:ad9951: " Lars-Peter Clausen
2013-10-05 11:02 ` Jonathan Cameron [this message]
2013-10-05 10:58 ` [PATCH 1/8] iio:ad5449: " Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=524FF1B6.2040804@kernel.org \
--to=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).