From: Lars-Peter Clausen <lars@metafoo.de>
To: Peter Meerwald <pmeerw@pmeerw.net>
Cc: linux-iio@vger.kernel.org
Subject: Re: [PATCH v3 02/10] staging:iio:hmc5843: Always read all channels values otherwise no updates
Date: Tue, 15 Oct 2013 07:39:13 +0200 [thread overview]
Message-ID: <525CD501.9020701@metafoo.de> (raw)
In-Reply-To: <1381786498-25954-3-git-send-email-pmeerw@pmeerw.net>
On 10/14/2013 11:34 PM, Peter Meerwald wrote:
> +/* Return the measurement value from the specified channel */
> +static int hmc5843_read_measurement(struct hmc5843_data *data,
> + int idx, int *val)
> +{
> + s32 result;
> + s16 values[3];
I'm currently trying to make iio pass `make C=2 CF=-D__CHECK_ENDIAN__`.
This should be __be16
> +
> + mutex_lock(&data->lock);
> + result = hmc5843_wait_measurement(data);
> + if (result < 0) {
> + mutex_unlock(&data->lock);
> + return result;
> + }
> + result = i2c_smbus_read_i2c_block_data(data->client,
> + HMC5843_DATA_OUT_MSB_REGS, sizeof(values), (u8 *) values);
> mutex_unlock(&data->lock);
> if (result < 0)
> return -EINVAL;
>
> - *val = sign_extend32(result, 15);
> + *val = sign_extend32(be16_to_cpu(values[idx]), 15);
> return IIO_VAL_INT;
> }
>
[...]
next prev parent reply other threads:[~2013-10-15 5:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-14 21:34 [PATCH v3 00/10] hmc5843 cleanup Peter Meerwald
2013-10-14 21:34 ` [PATCH v3 01/10] staging:iio:hmc5843: Use SCALE instead of magn_range Peter Meerwald
2013-10-15 22:14 ` Jonathan Cameron
2013-10-14 21:34 ` [PATCH v3 02/10] staging:iio:hmc5843: Always read all channels values otherwise no updates Peter Meerwald
2013-10-15 5:39 ` Lars-Peter Clausen [this message]
2013-10-14 21:34 ` [PATCH v3 03/10] staging:iio:hmc5843: Add trigger handling Peter Meerwald
2013-10-14 21:34 ` [PATCH v3 04/10] staging:iio:hmc5843: Remove ability to change operating mode Peter Meerwald
2013-10-14 21:34 ` [PATCH v3 05/10] staging:iio:hmc5843: Rename _configure() to _set_mode() Peter Meerwald
2013-10-14 21:34 ` [PATCH v3 06/10] staging:iio:hmc5843: Reorganize _set_meas_conf() Peter Meerwald
2013-10-14 21:34 ` [PATCH v3 07/10] staging:iio:hmc5843: Rename _set_rate() to _set_samp_freq() Peter Meerwald
2013-10-14 21:34 ` [PATCH v3 08/10] staging:iio:hmc5843: Introduce _set_range_gain() Peter Meerwald
2013-10-14 21:34 ` [PATCH v3 09/10] staging:iio:hmc5843: Check initialization and chip identifier Peter Meerwald
2013-10-14 21:34 ` [PATCH v3 10/10] staging:iio:hmc5843: Trivial cleanups Peter Meerwald
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=525CD501.9020701@metafoo.de \
--to=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).