From: Jonathan Cameron <jic23@kernel.org>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: linux-iio@vger.kernel.org, Denis Ciocca <denis.ciocca@st.com>
Subject: Re: [PATCH 09/17] iio:st_magn: Remove redundant call to iio_sw_buffer_preenable().
Date: Wed, 16 Oct 2013 19:14:14 +0100 [thread overview]
Message-ID: <525ED776.1010807@kernel.org> (raw)
In-Reply-To: <1381769370-17100-9-git-send-email-lars@metafoo.de>
On 10/14/13 17:49, Lars-Peter Clausen wrote:
> The equivalent of iio_sw_buffer_preenable() is now done in the IIO buffer core,
> so there is no need to do this from the driver anymore.
>
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
> Cc: Denis Ciocca <denis.ciocca@st.com>
Applied to the togreg branch of iio.git
Thanks
> ---
> drivers/iio/magnetometer/st_magn_buffer.c | 11 +----------
> 1 file changed, 1 insertion(+), 10 deletions(-)
>
> diff --git a/drivers/iio/magnetometer/st_magn_buffer.c b/drivers/iio/magnetometer/st_magn_buffer.c
> index 708857b..bf427dc 100644
> --- a/drivers/iio/magnetometer/st_magn_buffer.c
> +++ b/drivers/iio/magnetometer/st_magn_buffer.c
> @@ -25,16 +25,7 @@
>
> static int st_magn_buffer_preenable(struct iio_dev *indio_dev)
> {
> - int err;
> -
> - err = st_sensors_set_enable(indio_dev, true);
> - if (err < 0)
> - goto st_magn_set_enable_error;
> -
> - err = iio_sw_buffer_preenable(indio_dev);
> -
> -st_magn_set_enable_error:
> - return err;
> + return st_sensors_set_enable(indio_dev, true);
> }
>
> static int st_magn_buffer_postenable(struct iio_dev *indio_dev)
>
next prev parent reply other threads:[~2013-10-16 17:13 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-14 16:49 [PATCH 01/17] iio: Update buffer's bytes per datum after updating the scan mask Lars-Peter Clausen
2013-10-14 16:49 ` [PATCH 02/17] iio:st_accel: Drop redundant call to iio_sw_buffer_preenable() Lars-Peter Clausen
2013-10-16 18:11 ` Jonathan Cameron
2013-10-14 16:49 ` [PATCH 03/17] iio:ad7266: Remove redundant call to iio_sw_preenable() Lars-Peter Clausen
2013-10-16 18:12 ` Jonathan Cameron
2013-10-14 16:49 ` [PATCH 04/17] iio:ad7887: Remove redundant call to iio_sw_buffer_preenable() Lars-Peter Clausen
2013-10-16 18:12 ` Jonathan Cameron
2013-10-14 16:49 ` [PATCH 05/17] iio:ad_sigma_delta: " Lars-Peter Clausen
2013-10-16 18:12 ` Jonathan Cameron
2013-10-14 16:49 ` [PATCH 06/17] iio:ti_am335x: " Lars-Peter Clausen
2013-10-16 18:13 ` Jonathan Cameron
2013-10-14 16:49 ` [PATCH 07/17] iio:st_gyro: " Lars-Peter Clausen
2013-10-16 18:13 ` Jonathan Cameron
2013-10-14 16:49 ` [PATCH 08/17] iio:triggered-buffer: " Lars-Peter Clausen
2013-10-16 18:13 ` Jonathan Cameron
2013-10-14 16:49 ` [PATCH 09/17] iio:st_magn: " Lars-Peter Clausen
2013-10-16 18:14 ` Jonathan Cameron [this message]
2013-10-14 16:49 ` [PATCH 10/17] iio:st_pressure: " Lars-Peter Clausen
2013-10-16 18:14 ` Jonathan Cameron
2013-10-14 16:49 ` [PATCH 11/17] iio:gp2ap020a00f: " Lars-Peter Clausen
2013-10-16 18:14 ` Jonathan Cameron
2013-10-14 16:49 ` [PATCH 12/17] staging:iio:lis3l02dq: " Lars-Peter Clausen
2013-10-16 18:15 ` Jonathan Cameron
2013-10-14 16:49 ` [PATCH 13/17] staging:iio:mxs-lradc: " Lars-Peter Clausen
2013-10-16 18:15 ` Jonathan Cameron
2013-10-14 16:49 ` [PATCH 14/17] staging:iio:simple-dummy: " Lars-Peter Clausen
2013-10-16 18:16 ` Jonathan Cameron
2013-10-14 16:49 ` [PATCH 15/17] staging:iio:ad5933: " Lars-Peter Clausen
2013-10-16 18:16 ` Jonathan Cameron
2013-10-14 16:49 ` [PATCH 16/17] staging:iio:ade7758: " Lars-Peter Clausen
2013-10-16 18:16 ` Jonathan Cameron
2013-10-14 16:49 ` [PATCH 17/17] iio: Remove unused iio_sw_buffer_preenable() Lars-Peter Clausen
2013-10-16 18:17 ` Jonathan Cameron
2013-10-14 22:00 ` [PATCH 01/17] iio: Update buffer's bytes per datum after updating the scan mask Jonathan Cameron
2013-10-16 18:09 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=525ED776.1010807@kernel.org \
--to=jic23@kernel.org \
--cc=denis.ciocca@st.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).