From: Lars-Peter Clausen <lars@metafoo.de>
To: Harald Geyer <harald@ccbib.org>
Cc: Peter Meerwald <pmeerw@pmeerw.net>, linux-iio@vger.kernel.org
Subject: Re: [PATCH 2/2] iio: Add new driver dht11-gpio
Date: Wed, 23 Oct 2013 17:13:25 +0200 [thread overview]
Message-ID: <5267E795.7030804@metafoo.de> (raw)
In-Reply-To: <E1VYjUo-0000uN-OY@stardust.g4.wien.funkfeuer.at>
On 10/22/2013 11:28 PM, Harald Geyer wrote:
> Replying to both of your mails in one message here:
>
>>>> +config DHT11_GPIO
>>>> + tristate "DHT11 (and compatible sensors) driver"
>>>> + help
>>>> + This driver supports reading data via a single interrupts
>>
>> should probably depend on GENERIC_GPIO?
>
> After thinking about this a bit, I believe a dependency on
> OF_GPIO is necessary. Maybe also add an explicit dependency
> on GPIOLIB?
The of_gpio calls are stubbed out if OF_GPIO is not selected. So there is no
need to add the dependency and not having the dependency makes compile
testing easier on platforms which e.g. do not support OF. But the
GENERIC_GPIO symbol got removed recently, since everybody is using GPIOLIB
these days. So that's the right symbol to depend on.
- Lars
next prev parent reply other threads:[~2013-10-23 15:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-22 16:47 [PATCH 2/2] iio: Add new driver dht11-gpio Harald Geyer
2013-10-22 18:58 ` Peter Meerwald
2013-10-22 19:57 ` Peter Meerwald
2013-10-22 20:06 ` Harald Geyer
2013-10-22 20:20 ` Peter Meerwald
2013-10-22 21:28 ` Harald Geyer
2013-10-23 15:13 ` Lars-Peter Clausen [this message]
2013-10-25 11:47 ` [PATCH v2 " Harald Geyer
2013-11-23 11:40 ` Jonathan Cameron
2013-11-23 17:44 ` Harald Geyer
2013-11-24 18:36 ` Jonathan Cameron
2013-12-01 15:04 ` [PATCH v3 2/2] iio: Add new driver dht11 Harald Geyer
2013-12-03 20:19 ` Jonathan Cameron
2013-12-01 15:08 ` [PATCH v3 1/2] iio: Add support for humidity sensors Harald Geyer
2013-12-03 20:12 ` Jonathan Cameron
2013-10-22 22:44 ` [PATCH 2/2] iio: Add new driver dht11-gpio Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5267E795.7030804@metafoo.de \
--to=lars@metafoo.de \
--cc=harald@ccbib.org \
--cc=linux-iio@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).