From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out-048.synserver.de ([212.40.185.48]:1144 "EHLO smtp-out-024.synserver.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750936Ab3JWPN2 (ORCPT ); Wed, 23 Oct 2013 11:13:28 -0400 Message-ID: <5267E795.7030804@metafoo.de> Date: Wed, 23 Oct 2013 17:13:25 +0200 From: Lars-Peter Clausen MIME-Version: 1.0 To: Harald Geyer CC: Peter Meerwald , linux-iio@vger.kernel.org Subject: Re: [PATCH 2/2] iio: Add new driver dht11-gpio References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org On 10/22/2013 11:28 PM, Harald Geyer wrote: > Replying to both of your mails in one message here: > >>>> +config DHT11_GPIO >>>> + tristate "DHT11 (and compatible sensors) driver" >>>> + help >>>> + This driver supports reading data via a single interrupts >> >> should probably depend on GENERIC_GPIO? > > After thinking about this a bit, I believe a dependency on > OF_GPIO is necessary. Maybe also add an explicit dependency > on GPIOLIB? The of_gpio calls are stubbed out if OF_GPIO is not selected. So there is no need to add the dependency and not having the dependency makes compile testing easier on platforms which e.g. do not support OF. But the GENERIC_GPIO symbol got removed recently, since everybody is using GPIOLIB these days. So that's the right symbol to depend on. - Lars