From: Jonathan Cameron <jic23@kernel.org>
To: Sachin Kamat <sachin.kamat@linaro.org>, linux-iio@vger.kernel.org
Subject: Re: [PATCH 3/9] iio: accel: kxsd9: Remove redundant variable
Date: Thu, 24 Oct 2013 14:44:22 +0100 [thread overview]
Message-ID: <52692436.40207@kernel.org> (raw)
In-Reply-To: <1382615615-20153-3-git-send-email-sachin.kamat@linaro.org>
On 10/24/13 12:53, Sachin Kamat wrote:
> Return directly thereby eliminating an intermediate variable.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Applied to the togreg branch of iio.git
Thanks,
> ---
> drivers/iio/accel/kxsd9.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/iio/accel/kxsd9.c b/drivers/iio/accel/kxsd9.c
> index 709c132..d72118d 100644
> --- a/drivers/iio/accel/kxsd9.c
> +++ b/drivers/iio/accel/kxsd9.c
> @@ -222,7 +222,6 @@ static int kxsd9_probe(struct spi_device *spi)
> {
> struct iio_dev *indio_dev;
> struct kxsd9_state *st;
> - int ret;
>
> indio_dev = devm_iio_device_alloc(&spi->dev, sizeof(*st));
> if (!indio_dev)
> @@ -244,11 +243,7 @@ static int kxsd9_probe(struct spi_device *spi)
> spi_setup(spi);
> kxsd9_power_up(st);
>
> - ret = iio_device_register(indio_dev);
> - if (ret)
> - return ret;
> -
> - return 0;
> + return iio_device_register(indio_dev);
> }
>
> static int kxsd9_remove(struct spi_device *spi)
>
next prev parent reply other threads:[~2013-10-24 12:43 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-24 11:53 [PATCH 1/9] iio: core: Use pr_err instead of printk Sachin Kamat
2013-10-24 11:53 ` [PATCH 2/9] iio: core: Add misssing braces Sachin Kamat
2013-10-24 13:44 ` Jonathan Cameron
2013-10-24 11:53 ` [PATCH 3/9] iio: accel: kxsd9: Remove redundant variable Sachin Kamat
2013-10-24 13:44 ` Jonathan Cameron [this message]
2013-10-24 11:53 ` [PATCH 4/9] iio: adc: twl6030-gpadc: Remove redundant code Sachin Kamat
2013-10-24 13:49 ` Jonathan Cameron
2013-10-24 11:53 ` [PATCH 5/9] iio: dac: ad5421: " Sachin Kamat
2013-10-24 13:51 ` Jonathan Cameron
2013-10-24 11:53 ` [PATCH 6/9] iio: dac: ad5755: " Sachin Kamat
2013-10-24 13:51 ` Jonathan Cameron
2013-10-24 11:53 ` [PATCH 7/9] iio: dac: max517: Remove redundant variable Sachin Kamat
2013-10-24 13:52 ` Jonathan Cameron
2013-10-24 11:53 ` [PATCH 8/9] iio: dac: mcp4725: Remove redundant code Sachin Kamat
2013-10-24 13:53 ` Jonathan Cameron
2013-10-24 11:53 ` [PATCH 9/9] iio: light: vcnl4000: " Sachin Kamat
2013-10-24 13:53 ` Jonathan Cameron
2013-10-24 13:41 ` [PATCH 1/9] iio: core: Use pr_err instead of printk Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52692436.40207@kernel.org \
--to=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=sachin.kamat@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).